Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Klaviyo : Migrate to Manifest-only #54166

Merged
merged 9 commits into from
Feb 27, 2025

Conversation

topefolorunso
Copy link
Collaborator

@topefolorunso topefolorunso commented Feb 19, 2025

Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 3:15pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/klaviyo labels Feb 19, 2025
@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Feb 19, 2025

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (4e4f032)

@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Feb 19, 2025

CATs passed, only unit tests fail due to unresolved dependency issue (requests-mock)
cc: @natikgadzhi @ChristoGrab

@natikgadzhi
Copy link
Contributor

@darynaishchenko can you please give this a review and a quick spin? It looks like we should consider this AFTER we merge the API update, right?

@darynaishchenko
Copy link
Collaborator

@topefolorunso could you please fix failed unit tests?

@darynaishchenko
Copy link
Collaborator

@topefolorunso , overall LGTM, but can you fix unit tests and merge conflicts so we can run regression tests? Thanks!

@topefolorunso
Copy link
Collaborator Author

@darynaishchenko The failing unit test is due to missing request-mock package in the ci environment. All tests pass in local

@darynaishchenko
Copy link
Collaborator

@topefolorunso, you can try to add requests-mock dependency to [tool.poetry.group.dev.dependencies]group and run airbyte-ci connectors --name=source-klaviyo test --only-step=unit to reproduce the behavior. airbyte-ci docs
We need to make CI green to merge these changes.

@topefolorunso
Copy link
Collaborator Author

you can try to add requests-mock dependency to [tool.poetry.group.dev.dependencies]group

didn't work @darynaishchenko, got the same error
cc: @ChristoGrab

@darynaishchenko
Copy link
Collaborator

Regression tests:

Only one failure: Stream events has 7 more records in the target version (2560 vs. 2553).
Should be fine with this as events stream is incremental and data could be populated between reads

@darynaishchenko
Copy link
Collaborator

darynaishchenko commented Feb 27, 2025

/approve-regression-tests

Check job output.

✅ Approving regression tests

@DanyloGL
Copy link
Collaborator

@natikgadzhi this looks good, can we merge it today?

@natikgadzhi natikgadzhi merged commit 82b9d9f into master Feb 27, 2025
29 of 30 checks passed
@natikgadzhi natikgadzhi deleted the tope/klaviyo/migrate-manifest-only branch February 27, 2025 17:00
@natikgadzhi
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/klaviyo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants