✨ TikTok Marketing Source: By country daily/hourly report streams #55681

sheinbergon · 2025-03-10T16:48:04Z

What

Adds new daily/hourly reports streams with country breakdown. Unlike the existing audience reports, these base reports streams allow fetching some additional metrics (reach, being one of them). These streams are currently actively used in production using a modified version of the tiktok-marketing connector in our local K8s deployment, with great success

How

Added 4 new streams to the manifest.yaml, and new country_code dimension that was missing

Review guide

Simple update to manifest.yaml

User Impact

The user will be able to retrieve new streams with additional support metrics

Can this PR be safely reverted and rolled back?

YES 💚
NO ❌

vercel · 2025-03-10T16:48:08Z

@sheinbergon is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

sheinbergon · 2025-03-10T20:13:09Z

@natikgadzhi @marcosmarxm time and contribute this to the product, so we can you it in airbyte cloud. Can you please have look and confirm it's all good?

sheinbergon · 2025-03-12T09:05:08Z

@natikgadzhi @marcosmarxm this addition is crucial to us. Can you please have a look?

marcosmarxm · 2025-03-12T13:46:14Z

@sheinbergon I ask your patience. Our team has a backlog of community contribution.

vercel · 2025-03-12T18:54:00Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 12, 2025 7:00pm

natikgadzhi

This overall looks good. I am not entirely certain about adding country_code to base_report.

I have a couple of options in mind:

Either we get @tolik0's or @agarctfi approval and merge as is
Or we do progressive rollout

natikgadzhi · 2025-03-12T18:54:29Z

airbyte-integrations/connectors/source-tiktok-marketing/acceptance-test-config.yml

@@ -60,6 +60,14 @@ acceptance_tests:
            bypass_reason: "No data in the integration test account. We should seed the sandbox later on."
          - name: pixel_events_statistics
            bypass_reason: "No data in the integration test account. We should seed the sandbox later on."
+          - name: ads_reports_by_country_daily


Oh my sweet lordy I hate CATs so much

Is there's something for me to do with this comment 😅? If not, can I resolve it

airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml

natikgadzhi · 2025-03-12T18:58:41Z

airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/manifest.yaml

+  ads_reports_by_country_daily_stream:
+    type: DeclarativeStream
+    name: ads_reports_by_country_daily
+    $parameters:


I don't like the use of $parameters, but it's the best approach for this PR as the other streams are using them.

Ok. So this is not an issue, right? can this be resolved?

natikgadzhi · 2025-03-12T19:00:51Z

airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/manifest.yaml

@@ -3558,6 +3826,11 @@ definitions:
          type:
            - "null"
            - integer
+        country_code:


@sheinbergon @tolik0 is base_report used in any other streams?Is the country_code always there? Is it safe to add here, or should we add this at the level of daily reports instead?

@natikgadzhi it can be used for other streams. Currently not present of course. Adding this, I saw no other streams break. Again, the reason for adding this is to allow access to by ad_id/date/country breakdown for BASIC tiktok reports. It's very standartized access in their API's documentation. If there's another way for doing that, please let me know

@natikgadzhi @tolik0 a kind reminder about this concern

sheinbergon · 2025-03-12T20:17:41Z

This overall looks good. I am not entirely certain about adding country_code to base_report.

I have a couple of options in mind:

Either we get @tolik0's or @agarctfi approval and merge as is

Or we do progressive rollout

Thank you for reviewing and suggesting fixes. What do you mean by doing a "progressive rollout"?

…ta.yaml Co-authored-by: Natik Gadzhi <[email protected]>

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Mar 10, 2025

sheinbergon temporarily deployed to community-ci-auto March 10, 2025 16:48 — with GitHub Actions Inactive

sheinbergon had a problem deploying to community-ci March 10, 2025 16:48 — with GitHub Actions Error

octavia-squidington-iii added community connectors/source/tiktok-marketing labels Mar 10, 2025

sheinbergon temporarily deployed to community-ci-auto March 10, 2025 17:55 — with GitHub Actions Inactive

sheinbergon had a problem deploying to community-ci March 10, 2025 17:55 — with GitHub Actions Error

sheinbergon force-pushed the sheinbergon/source-tiktok-marketing-new-streams branch from 44ab08f to ea19e8b Compare March 10, 2025 18:02

sheinbergon temporarily deployed to community-ci-auto March 10, 2025 18:02 — with GitHub Actions Inactive

sheinbergon had a problem deploying to community-ci March 10, 2025 18:02 — with GitHub Actions Error

sheinbergon force-pushed the sheinbergon/source-tiktok-marketing-new-streams branch from ea19e8b to adb6f53 Compare March 10, 2025 20:08

sheinbergon had a problem deploying to community-ci March 10, 2025 20:08 — with GitHub Actions Error

sheinbergon temporarily deployed to community-ci-auto March 10, 2025 20:08 — with GitHub Actions Inactive

sheinbergon had a problem deploying to community-ci March 10, 2025 20:08 — with GitHub Actions Error

sheinbergon force-pushed the sheinbergon/source-tiktok-marketing-new-streams branch from adb6f53 to a3dd3f4 Compare March 11, 2025 07:27

sheinbergon had a problem deploying to community-ci March 11, 2025 07:27 — with GitHub Actions Error

sheinbergon temporarily deployed to community-ci-auto March 11, 2025 07:27 — with GitHub Actions Inactive

sheinbergon had a problem deploying to community-ci March 12, 2025 09:04 — with GitHub Actions Error

sheinbergon temporarily deployed to community-ci-auto March 12, 2025 09:04 — with GitHub Actions Inactive

sheinbergon force-pushed the sheinbergon/source-tiktok-marketing-new-streams branch from 8444253 to 0cb055b Compare March 12, 2025 14:14

vercel bot deployed to Preview March 12, 2025 19:00 View deployment

natikgadzhi reviewed Mar 12, 2025

View reviewed changes

sheinbergon had a problem deploying to community-ci-auto March 12, 2025 20:14 — with GitHub Actions Error

sheinbergon had a problem deploying to community-ci March 12, 2025 20:14 — with GitHub Actions Error

sheinbergon force-pushed the sheinbergon/source-tiktok-marketing-new-streams branch from f743704 to 240b7a7 Compare March 12, 2025 20:17

sheinbergon temporarily deployed to community-ci-auto March 12, 2025 20:18 — with GitHub Actions Inactive

sheinbergon had a problem deploying to community-ci March 12, 2025 20:18 — with GitHub Actions Error

sheinbergon force-pushed the sheinbergon/source-tiktok-marketing-new-streams branch from 240b7a7 to 5b4c792 Compare March 13, 2025 08:59

sheinbergon had a problem deploying to community-ci March 13, 2025 09:00 — with GitHub Actions Error

sheinbergon temporarily deployed to community-ci-auto March 13, 2025 09:00 — with GitHub Actions Inactive

sheinbergon force-pushed the sheinbergon/source-tiktok-marketing-new-streams branch from 5b4c792 to 069419b Compare March 16, 2025 01:42

sheinbergon had a problem deploying to community-ci March 16, 2025 01:43 — with GitHub Actions Error

sheinbergon temporarily deployed to community-ci-auto March 16, 2025 01:43 — with GitHub Actions Inactive

sheinbergon force-pushed the sheinbergon/source-tiktok-marketing-new-streams branch from 069419b to a698b45 Compare March 17, 2025 15:21

sheinbergon and others added 6 commits March 20, 2025 11:52

New ads/adgroups daily/hourly reports by country

23f317b

Documentation update

e492d85

formatting fixes

40121f6

Version bump

3a59d7a

Update airbyte-integrations/connectors/source-tiktok-marketing/metada…

281517c

…ta.yaml Co-authored-by: Natik Gadzhi <[email protected]>

Update airbyte-integrations/connectors/source-tiktok-marketing/metada…

321b40a

…ta.yaml Co-authored-by: Natik Gadzhi <[email protected]>

sheinbergon force-pushed the sheinbergon/source-tiktok-marketing-new-streams branch from a698b45 to 321b40a Compare March 20, 2025 09:52

sheinbergon temporarily deployed to community-ci-auto March 20, 2025 09:52 — with GitHub Actions Inactive

sheinbergon requested a deployment to community-ci March 20, 2025 09:52 — with GitHub Actions Waiting

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ TikTok Marketing Source: By country daily/hourly report streams #55681

✨ TikTok Marketing Source: By country daily/hourly report streams #55681

sheinbergon commented Mar 10, 2025 •

edited

Loading

vercel bot commented Mar 10, 2025

sheinbergon commented Mar 10, 2025

sheinbergon commented Mar 12, 2025

marcosmarxm commented Mar 12, 2025

vercel bot commented Mar 12, 2025 •

edited

Loading

natikgadzhi left a comment

natikgadzhi Mar 12, 2025

sheinbergon Mar 12, 2025

sheinbergon Mar 17, 2025

natikgadzhi Mar 12, 2025

sheinbergon Mar 12, 2025

natikgadzhi Mar 12, 2025

sheinbergon Mar 12, 2025

sheinbergon Mar 17, 2025

sheinbergon commented Mar 12, 2025

✨ TikTok Marketing Source: By country daily/hourly report streams #55681

Are you sure you want to change the base?

✨ TikTok Marketing Source: By country daily/hourly report streams #55681

Conversation

sheinbergon commented Mar 10, 2025 • edited Loading

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

vercel bot commented Mar 10, 2025

sheinbergon commented Mar 10, 2025

sheinbergon commented Mar 12, 2025

marcosmarxm commented Mar 12, 2025

vercel bot commented Mar 12, 2025 • edited Loading

natikgadzhi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sheinbergon commented Mar 12, 2025

sheinbergon commented Mar 10, 2025 •

edited

Loading

vercel bot commented Mar 12, 2025 •

edited

Loading