Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Outbrain Amplify: Add new optional parameter 'conversionsByClickDate' for performance reports #55746

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

FelixJetschiny
Copy link

@FelixJetschiny FelixJetschiny commented Mar 13, 2025

What

Addition of a new optional parameter conversionsByClickDate for Outbrain Amplify performance reports. Users are now able to define the conversion metrics in the performance reports individually.

How

New optional parameter is added. If not defined in connection, value will be conversionsByClickDate=false, which is the default behavior as before.

Review guide

  1. source.py -> Consideration of new parameter in report streams
  2. spec.yaml -> Definition of parameter in connector specifications

User Impact

Option to choose between conversion metrics defined as "Time of Conversion" (default) and "Time of Click/View"

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Mar 13, 2025

@FelixJetschiny is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trigger tests to validate your changes @FelixJetschiny

@marcosmarxm
Copy link
Member

marcosmarxm commented Mar 14, 2025

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (310f518)

Copy link

vercel bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 1:20pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting Contributor
Development

Successfully merging this pull request may close these issues.

5 participants