Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hard-deprecate connector generator script #55788

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

natikgadzhi
Copy link
Contributor

@natikgadzhi natikgadzhi commented Mar 16, 2025

What

This pull request removes the ./generate connector generator script and it's templates. The script used Node 16 and required Docker to make new connectors — it's 4 years old.

  • For Python connectors, we want to nudge people to start with Connector Builder always. We might want to implement a flow in Builder that would dump the full connector directory on disk so the user can add a pyproject.toml file, but as it's an advanced flow, we're fine removing the generators without this in place.
  • For Java connectors, existing generator templates are outdated anyway, and we don't want people to use them.

Closes https://github.com/airbytehq/airbyte-internal-issues/issues/11926

How

  1. Removed generators
  2. Removed all references to them in documentation.
  3. Removed 2 python connector guides that are no longer up to date or relevant.

Review guide

Click around docs site preview on Vercel.

User Impact

None.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@natikgadzhi natikgadzhi requested a review from a team as a code owner March 16, 2025 21:10
@natikgadzhi natikgadzhi requested review from ian-at-airbyte and removed request for a team March 16, 2025 21:10
Copy link

vercel bot commented Mar 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 16, 2025 9:34pm

@natikgadzhi natikgadzhi enabled auto-merge (squash) March 16, 2025 21:28
@natikgadzhi
Copy link
Contributor Author

Automerge on.

Copy link
Contributor

@ian-at-airbyte ian-at-airbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs component looks good to me I think. I left a couple of minor suggestions. Since automerge is on, I will not explicitly approve but consider this my approval.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a problem related to this set of changes, but it's applicable anyway.

We're using the displayed_sidebar: docs metadata, but this file has not been added to docusaurus/sidebars.js. I think it would be better to do the latter and not the former. That way the topic has a "real" home on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants