-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: hard-deprecate connector generator script #55788
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Automerge on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs component looks good to me I think. I left a couple of minor suggestions. Since automerge is on, I will not explicitly approve but consider this my approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a problem related to this set of changes, but it's applicable anyway.
We're using the displayed_sidebar: docs
metadata, but this file has not been added to docusaurus/sidebars.js
. I think it would be better to do the latter and not the former. That way the topic has a "real" home on the site.
What
This pull request removes the
./generate
connector generator script and it's templates. The script used Node 16 and required Docker to make new connectors — it's 4 years old.pyproject.toml
file, but as it's an advanced flow, we're fine removing the generators without this in place.Closes https://github.com/airbytehq/airbyte-internal-issues/issues/11926
How
Review guide
Click around docs site preview on Vercel.
User Impact
None.
Can this PR be safely reverted and rolled back?