Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Chargebee: add discount_quantity to coupon stream #55799

Merged
merged 4 commits into from
Mar 18, 2025

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Mar 17, 2025

What

Following a request here: Adding the new field discount_quantity to stream coupon.

How

It is already returned in the records. We just need to add it to the schema.

Review guide

User Impact

The destination should pick the discount_quantity field for the coupon stream now.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 2:50pm

@maxi297 maxi297 requested a review from brianjlai March 17, 2025 16:45
@maxi297 maxi297 changed the title ❇️ Source Chargebee: add discount_quantity to coupon stream ✨ Source Chargebee: add discount_quantity to coupon stream Mar 17, 2025
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send it!

@maxi297 maxi297 merged commit 8db9864 into master Mar 18, 2025
25 of 27 checks passed
@maxi297 maxi297 deleted the maxi297/chargebee_add_discount_quantity_to_coupon branch March 18, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants