Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destination-teradata: Added Query Band Feature Support #55800

Merged

Conversation

sc250072
Copy link
Contributor

What

Added Teradata query band feature to Airbyte Teradata connector. With this feature, Airbyte user can set custom query band for transactions happening from Airbyte to Teradata.

How

User can provide custom Query Band in new UI field called Query Band of Teradata Destination.

Review guide

  1. airbyte-integrations/connectors/destination-teradata/build.gradle
  2. airbyte-integrations/connectors/destination-teradata/metadata.yaml
  3. airbyte-integrations/connectors/destination-teradata/src/main/kotlin/io/airbyte/integrations/destination/teradata/TeradataDestination.kt
  4. airbyte-integrations/connectors/destination-teradata/src/main/kotlin/io/airbyte/integrations/destination/teradata/util/TeradataConstants.kt
  5. airbyte-integrations/connectors/destination-teradata/src/main/resources/spec.json
  6. airbyte-integrations/connectors/destination-teradata/src/test-integration/java/io/airbyte/integrations/destination/teradata/TeradataDestinationAcceptanceTest.java
  7. airbyte-integrations/connectors/destination-teradata/src/test/java/io/airbyte/integrations/destination/teradata/TeradataDestinationTest.java
  8. airbyte-integrations/connectors/destination-teradata/src/test/java/io/airbyte/integrations/destination/teradata/TeradataSqlOperationsTest.java

User Impact

  1. User can use this field to provide Query Band for new connections.
  2. User can also provide Query Band for old connections by editing Teradata Destination connection page

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Reports generated before raising PR

  • Snyk scan for Security Vulnerabilities - ### 0 Vulnerabilities found
    image

  • Code coverage report. 76% is the code coverage number
    image

image

  • Java source code formatter success on Connector code
    image

  • Unit tests and Integration tests success. QA tests are failing due to infrastructure issue.
    image

@sc250072 sc250072 requested a review from a team as a code owner March 17, 2025 17:00
Copy link

vercel bot commented Mar 17, 2025

@sc250072 is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 6:11pm

@marcosmarxm marcosmarxm merged commit 3e3eefb into airbytehq:master Mar 20, 2025
26 checks passed
Valgard pushed a commit to mayflower/airbyte that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants