Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Amazon Ads: Update the manifest to use the latest AsyncRetriever changes #55806

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

topefolorunso
Copy link
Collaborator

Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 4:36pm

@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Mar 18, 2025

@bazarnov See error below in unit test

[omitting 10683115524 bytes]...al\n    raise ValueError(\nValueError: Jinja macro has undeclared variables: {'creation_response'}.
Context: {'config': {'client_id': '****', 'client_secret': '****', 'access_token': '****', 'refresh_token': '****', 'region': 'NA', 
'report_wait_timeout': 120, 'profiles': [1]}, 'parameters': {}, 'stream_slice': {}, 'next_page_token': None, 'stream_interval': {}, 
'stream_partition': {}}\n"}}

@bazarnov
Copy link
Collaborator

bazarnov commented Mar 18, 2025

@bazarnov See error below in unit test

[omitting 10683115524 bytes]...al\n    raise ValueError(\nValueError: Jinja macro has undeclared variables: {'creation_response'}.
Context: {'config': {'client_id': '****', 'client_secret': '****', 'access_token': '****', 'refresh_token': '****', 'region': 'NA', 
'report_wait_timeout': 120, 'profiles': [1]}, 'parameters': {}, 'stream_slice': {}, 'next_page_token': None, 'stream_interval': {}, 
'stream_partition': {}}\n"}}

I think I got the problem, we need an additional interpolation context, here, basically, and eventually pass it from here. Which requires more CDK work to be able to interpolate in the request_headers. For the AsyncRetriever, we have url_base and path to use the interpolation context mentioned in the Error. Thanks for highlighting this @topefolorunso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants