Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: sync failure webhooks gain errorType and errorOrigin #55809

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

evantahler
Copy link
Contributor

Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 10:57pm

Copy link
Contributor

@ian-at-airbyte ian-at-airbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor suggestion.

@@ -96,6 +100,8 @@ Airbyte passes both the `data` payload along with text blocks that are intended
}
```

Note that `errorType` refers to the type of error that occurred, and may indicate the need for a followup action. For example `config_error` indicates a problem with the source or destination configuration (look to `errorOrigin`), while `transient_error` indicates a temporary issue that may resolve itself.

Copy link
Contributor

@ian-at-airbyte ian-at-airbyte Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment: it looks like these are the only two possible values, but the way the example is written, it feels like other error types might be possible. As a reader I'd feel more confident if we were firm about the possibilities here. "Two error types are possible: config_error and transient_error..." and so forth.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree! I'd much rather link out to another page where we enumerate all the possible failure types... do we have that? I can't find it. There's:

  • config_error
  • system_error
  • transient_error
  • ... and others!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I can find. ChatGPT wasn't much help which tells me this has probably never been documented publicly. Maybe let's merge this for now and I'll see if Devin can put together a list quickly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evantahler evantahler merged commit ca054bd into master Mar 18, 2025
22 checks passed
@evantahler evantahler deleted the evan-webhook-errorType-docs branch March 18, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants