Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source HubSpot: add userIdIncludingInactive to owners and owners_archived streams #55822

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

samieid93
Copy link

@samieid93 samieid93 commented Mar 18, 2025

What

Adds userIdIcludingInvative fields to owners and owners_archived streams. This field exists in HubSpot V3 owners API.

How

Only needed to update the schemas for owners and owners_archived streams. When running poetry run source-hubspot read --config secrets/config.json --catalog integration_tests/basic_read_catalog.json, I realized that the field was actually read from HubSpot.

Review guide

Review schema files.

User Impact

The user will be able to sync this field.

Can this PR be safely reverted and rolled back?

  • YES 💚

@samieid93 samieid93 requested a review from a team as a code owner March 18, 2025 16:20
Copy link

vercel bot commented Mar 18, 2025

@samieid93 is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @marcosmarxm, how do we make this happen?

@marcosmarxm
Copy link
Member

/bump-version type="patch" changelog="include fields to owners and owners_archived streams"

@marcosmarxm
Copy link
Member

The CI pipeline is broken. Once it is fixed, I will merge the contribution.

@samieid93
Copy link
Author

/bump-version type="patch" changelog="include fields to owners and owners_archived streams"

Good catch, thanks. Done in 872c480

@samieid93
Copy link
Author

The CI pipeline is broken. Once it is fixed, I will merge the contribution.

Made it a patch bump in b039f95 instead of minor as per your PR comment. That being said, the PR handbook says that "Adding a column to a stream's schema in a connector's catalog" should be a minor bump. Let me know if I should revert back.

@samieid93
Copy link
Author

/bump-version type="patch" changelog="include fields to owners and owners_archived streams"

I don't see a changelog for source hubspot. Where should I add this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants