-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source HubSpot: add userIdIncludingInactive
to owners
and owners_archived
streams
#55822
base: master
Are you sure you want to change the base?
✨ Source HubSpot: add userIdIncludingInactive
to owners
and owners_archived
streams
#55822
Conversation
@samieid93 is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @marcosmarxm, how do we make this happen?
/bump-version type="patch" changelog="include fields to owners and owners_archived streams" |
The CI pipeline is broken. Once it is fixed, I will merge the contribution. |
Good catch, thanks. Done in 872c480 |
Made it a patch bump in b039f95 instead of minor as per your PR comment. That being said, the PR handbook says that "Adding a column to a stream's schema in a connector's catalog" should be a minor bump. Let me know if I should revert back. |
I don't see a changelog for source hubspot. Where should I add this? |
What
Adds
userIdIcludingInvative
fields toowners
andowners_archived
streams. This field exists in HubSpot V3 owners API.How
Only needed to update the schemas for
owners
andowners_archived
streams. When runningpoetry run source-hubspot read --config secrets/config.json --catalog integration_tests/basic_read_catalog.json
, I realized that the field was actually read from HubSpot.Review guide
Review schema files.
User Impact
The user will be able to sync this field.
Can this PR be safely reverted and rolled back?