Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45782: [GLib] Check only the first line for validation error #45783

Merged
merged 1 commit into from
Mar 19, 2025
Merged

GH-45782: [GLib] Check only the first line for validation error #45783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions c_glib/test/test-array.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,11 @@ def test_valid
def test_invalid
message = "[array][validate]: Invalid: Array length is negative"
array = Arrow::Int8Array.new(-1, Arrow::Buffer.new(""), Arrow::Buffer.new(""), -1)
assert_raise(Arrow::Error::Invalid.new(message)) do
error = assert_raise(Arrow::Error::Invalid) do
array.validate
end
assert_equal(message,
error.message.lines.first.chomp)
end
end

Expand All @@ -224,9 +226,11 @@ def test_invalid
Arrow::Buffer.new([0b01].pack("C*")),
-1)

assert_raise(Arrow::Error::Invalid.new(message)) do
error = assert_raise(Arrow::Error::Invalid) do
array.validate_full
end
assert_equal(message,
error.message.lines.first.chomp)
end
end
end
8 changes: 6 additions & 2 deletions c_glib/test/test-record-batch.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,11 @@ def test_invalid
n_rows = @id_value.length + 1 # incorrect number of rows

record_batch = Arrow::RecordBatch.new(@schema, n_rows, @values)
assert_raise(Arrow::Error::Invalid.new(message)) do
error = assert_raise(Arrow::Error::Invalid) do
record_batch.validate
end
assert_equal(message,
error.message.lines.first.chomp)
end
end

Expand Down Expand Up @@ -257,9 +259,11 @@ def test_invalid
columns = [@uint8_value, @invalid_name_value]
record_batch = Arrow::RecordBatch.new(@schema, @n_rows, columns)

assert_raise(Arrow::Error::Invalid.new(message)) do
error = assert_raise(Arrow::Error::Invalid) do
record_batch.validate_full
end
assert_equal(message,
error.message.lines.first.chomp)
end
end
end
Expand Down
8 changes: 6 additions & 2 deletions c_glib/test/test-table.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,9 +268,11 @@ def test_invalid

invalid_values = [@id_array, build_string_array(["abc", "def"])]
table = Arrow::Table.new(@schema, invalid_values)
assert_raise(Arrow::Error::Invalid.new(message)) do
error = assert_raise(Arrow::Error::Invalid) do
table.validate
end
assert_equal(message,
error.message.lines.first.chomp)
end
end

Expand Down Expand Up @@ -308,9 +310,11 @@ def test_invalid
columns = [@id_values, @invalid_name_values]
table = Arrow::Table.new(@schema, columns)

assert_raise(Arrow::Error::Invalid.new(message)) do
error = assert_raise(Arrow::Error::Invalid) do
table.validate_full
end
assert_equal(message,
error.message.lines.first.chomp)
end
end

Expand Down
Loading