Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List free IPs when performing associate IPAddress operation #155

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

Pearl1594
Copy link
Contributor

This PR list free IPs as opposed to the allocated IPs when trying associate an IP to a network

Before fix:

image

which are the list of allocated IPs:
image

After fix:

image

@weizhouapache
Copy link
Member

nice fix !

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM but some extra debug logs

@Pearl1594 Pearl1594 requested a review from shwstppr December 6, 2024 11:33
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@winterhazel winterhazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested, looks good

@rohityadavcloud rohityadavcloud merged commit 38cef54 into main Mar 19, 2025
2 checks passed
@rohityadavcloud rohityadavcloud deleted the list-free-ips-associate-ips branch March 19, 2025 03:40
@rohityadavcloud rohityadavcloud added this to the 6.5.0 milestone Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants