HIVE-28417: Bump Log4j2 to 2.24.3 #5636
Conversation
asf-ci-hive
added
tests pending
tests failed
and removed
tests pending
tests failed
labels
InvisibleProgrammer
force-pushed
the
HIVE-28733_v2
branch
from
7a3c7f7 to
aa3f938
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
…M Native Image (apache#5375)(Ling Hengqian, reviewed by Raghav Aggarwal, Butao Zhang) (cherry picked from commit 548990d)
InvisibleProgrammer
force-pushed
the
HIVE-28733_v2
branch
from
aa3f938 to
11e0111
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
tests failed
labels
|
| @@ -367,9 +367,8 @@ | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.apache.logging.log4j</groupId> | |||
| <artifactId>log4j-core</artifactId> | |||
| <artifactId>log4j-core-test</artifactId> | |||
There was a problem hiding this comment.
This change upgrades from 2.18.0 to 2.24.3.
Until 2.20.x, log4j-core provided the tests jar as well. That was the tests classifier that you see below. It was at line 372.
2.18 jars: https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j-core/2.18.0/
At 2.20, they rearranged their packaging strategy. They started to provide different jar files and also, moved some namespaces as well.
The log4j-core-test artifact that you see means now we are using the artifact that log4j created to publish the test jars separately: https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j-core/2.24.3/
There was a problem hiding this comment.
+1 LGTM Thanks @InvisibleProgrammer
I will keep this PR open for a few days & hope others who are interested in this PR give comments.
|
Hi @zhangbutao , Thanks, |
…, Zsolt Miskolczi，reviewed by Raghav Aggarwal, Butao Zhang) (apache#5636)" This reverts commit 92a5335.
This PR is based on #5375 (Thx linghengqian and @zhangbutao )
It upgrades log4j to 2.24.3
What changes were proposed in this pull request?
log4j to 2.24.3
Why are the changes needed?
apache/logging-log4j2#1391
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
Yes
How was this patch tested?
-- This PR: 106494 tests (https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5636/5/tests)
-- Latest green test on master: 106491 tests (https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/master/2411/tests)