[HUDI-1517] create marker file for every log file #13007
+2,685
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… marker-based rollback (apache#11830)
|
Some of the tests in TestHoodieBackedMetadata which were failing in master have been disabled. Created HUDI-9221 to track these test failures. |
Closed
4 tasks
nsivabalan
reviewed
Mar 25, 2025
| @@ -754,6 +754,11 @@ public HoodieTestTable withLogMarkerFile(String partitionPath, String fileName) | |||
| return this; | |||
| } | |||
|
|
|||
| // public HoodieTestTable withLogMarkerFile(String partitionPath, String fileId, IOType ioType) throws IOException { | |||
| @@ -141,7 +141,7 @@ private Map<String, Long> createLogFilesAndMarkersToRollback(String partition, | |||
| } catch (IOException e) { | |||
| throw new RuntimeException(e); | |||
| } | |||
| }).collect(Collectors.toMap(Function.identity(), e -> 1L)); | |||
There was a problem hiding this comment.
why flipping the size here? should we expect the size to be non 0 somewhere down the line and hence we added 1 as length here.
| @@ -258,6 +259,7 @@ public void testMetadataTableBootstrap(HoodieTableType tableType, boolean addRol | |||
| validateMetadata(testTable, true); | |||
| } | |||
|
|
|||
| @Disabled("HUDI-9221") | |||
There was a problem hiding this comment.
we might need to investigate and re-enable these tests.
| @@ -100,7 +102,7 @@ protected HoodieWriteConfig getConfigToTestMDTRollbacks(Boolean autoCommit) { | |||
| } | |||
|
|
|||
| protected HoodieWriteConfig getConfigToTestMDTRollbacks(Boolean autoCommit, Boolean mdtEnable) { | |||
| return HoodieWriteConfig.newBuilder() | |||
There was a problem hiding this comment.
if this entire class is meant for table version 6, can we rename the test class accordingly.
| } | ||
|
|
||
| /** | ||
| * Scenario: data table is updated, no changes to MDT | ||
| */ | ||
| protected void testRollbackWithFailurePreMDT(HoodieTableType tableType) throws Exception { | ||
| initBasePath(); | ||
| HoodieTableMetaClient metaClient = getHoodieMetaClient(tableType); | ||
| TypedProperties props = new TypedProperties(); |
There was a problem hiding this comment.
can we add a validation at the end of every test to confirm that table config -> table version is 6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
The PR cherry-picks the commit (which tracks marker file for every log file and handles error scenarios like repeated rollbacks, spurious log files etc.) made for 0.15.0 release and adds it to 1.0 for table version 6 compatibility.
https://github.com/apache/hudi/pull/11187/files#diff-9a401e6d5a736a9601567c006c3e66c1b5da1e8f7670addc366ca72a6db73872
Impact
NA
Risk level (write none, low medium or high below)
low
Documentation Update
NA
Contributor's checklist