-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of onMatch
and onMismatch
attributes in the properties configuration format
#2791
Comments
Hi @linghengqian, Could you point us to how you generate the GraalVM image? As almost all filters (except |
|
The problem is due to a typo in your configuration file: logger.CBORuleLogger.filter.marker.type = MarkerFilter
logger.CBORuleLogger.filter.marker.marker = FULL_PLAN
logger.CBORuleLogger.filter.marker.onMatch = DENY
logger.CBORuleLogger.filter.marker.onMisMatch = NEUTRAL You have Lines 234 to 236 in eaae9e3
Lines 462 to 465 in eaae9e3
Lines 29 to 37 in eaae9e3
Since you don't have an Remark: Fixing this also fixes LOG4J2-2931, so I am redirecting that issue here. PS: I noticed that Apache Hive uses a pre-2.6 properties configuration format (the |
onMismatch
of MarkerFilter
is no longer availableonMatch
and onMismatch
attributes in the properties configuration format
2024-08-02T10:55:16.634Z main WARN The use of package scanning to locate plugins is deprecated and will be removed in a future release
2024-08-02T10:55:16.650Z main WARN The use of package scanning to locate plugins is deprecated and will be removed in a future release
2024-08-02T10:55:16.670Z main WARN The use of package scanning to locate plugins is deprecated and will be removed in a future release
2024-08-02T10:55:16.686Z main WARN The use of package scanning to locate plugins is deprecated and will be removed in a future release
|
Two tests in `hplsql` module make assertions on the output to `System.out` and `System.err`. This makes the tests fragile to any other output that might appear there (see apache/logging-log4j2#2791 for example). This PR introduces a custom `Console` implementation to capture the output of these tests and make them independent from whatever is printed to the standard output and error descriptors.
There is no problem in Apache Hive: I checked that the appropriate annotation processor is configured in the
I believe that the problem breaks down to a missing null-check:
BTW: All the problems you are having are due to the fact that |
|
Hi, I'd like to work on this issue. Could you please assign it to me? |
I assigned the issue to you, thanks for the help. |
@aadvik93 are you still working on this? Otherwise, I would be willing to take this one. |
…Attributte (apache#2791) + more appropriate method name
+ made all Default***Builder implementations @ProviderrType + added setXXXAttribute method to some component builder interfaces with default implementations + added JSpecify @NullMarked to packages and @nullable where approrpiate to fields/mehods (per last PR review) + deprecated ComponentBuilder#addAttribute(...) methods and replaced with ComponentBuilder#setAttribute(...) methods in line with other builders (i.e. Plugins) - also since they don't just add but also remove if the value is null + reorganized ConfigurationBuilder to group getters, setters, builder factory methods + incremented package-info.java @Version annoations + added some null-guards in BuiltConfiguration#setup() + moved DeffaultConfigurationBuilder XML generation code from top to bottom of source file + removed "extra" attributes in Default***Builder constructors and replaced with setXXXAttribute chained calls in DefaultConfigurrationBuilder#newXXX(...) convenience methods + javadoc'd both packages (fixing documentation errors)
…instead of void (apache#2791) + added @BaselineIgnore due to API change (but breaks no code)
PR submitted - scope expanded per @ppkarwasz PR review to include a general overhaul of the |
Description
onMismatch
ofMarkerFilter
is no longer available. This was actually found from HIVE-28417: Bump Log4j2 to 2.24.1 to facilitate compilation of GraalVM Native Image hive#5375 . It can be reproduced in both2.23.0
and2.23.1
. This will be reflected in a log similar toERROR MarkerFilter contains an invalid element or attribute "onMismatch"
.Configuration
Version: [Log4j version]
2.23.0
Operating system: [OS and version]
Ubuntu WSL 22.04.4
JDK: [JDK distribution and version]
8.0.422-tem
onSDKMAN!
Logs
Reproduction
/hive/data/conf/hive-log4j2.properties
.The text was updated successfully, but these errors were encountered: