Repair or remove ineffective tests #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
reviewed
Feb 7, 2024
log4j-api-test/src/test/java/org/apache/logging/log4j/status/StatusLoggerSerializationTest.java
Show resolved
Hide resolved
log4j-core-test/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigTest3.java
Show resolved
Hide resolved
|
If I can be blunt most of our tests are "ineffective", since they cover a lot of common code, but don't always cover all the functionalities of the tested component. |
|
@ppkarwasz, I have checked misnamed test classes. If they contain tests that are not covered by other (effective) test classes, I tried to fix them, otherwise, I removed them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to repair, and if cannot, removes ineffective tests.