Revamp the Lookups page
#2736
Merged
Revamp the Lookups page
#2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We revamp the `Lookups` page by:
* Adding information on different evaluation contexts supported by lookups.
* Adding a cheatsheet on which lookup is available in which evaluation context. E.g., using `$${sys:something}` on a per-event level is a major performance waster.
* Removing the description of the broken `jvmrunargs` lookup (see #2726).
* Improving the description of the `main` lookup by providing a code example that does not fail if the user switches logging implementations.
* Shortening and improving the description of other lookups.
vy
requested changes
Jul 12, 2024
src/site/antora/modules/ROOT/examples/manual/lookups/MainArgsExample.java
Show resolved
Hide resolved
Co-authored-by: Volkan Yazıcı <[email protected]>
ppkarwasz
force-pushed
the
doc/2.x/lookups
branch
from
17b8eb7 to
fd9f75e
Compare
vy
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We revamp the
Lookupspage by:$${sys:something}on a per-event level is a major performance waster.jvmrunargslookup (see Thejvmrunargslookup is always empty #2726).mainlookup by providing a code example that does not fail if the user switches logging implementations.Closes #2526.