Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements an event service and demonstrates its use for sending/receiving SSL key/trust store changes #3378

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

MichaelMorrisEst
Copy link
Contributor

Intended as a means to discuss what the implementation for #3074 (comment) should look like

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

…ving events for SSL key/trust store changes

Signed-off-by: MichaelMorris <[email protected]>
Copy link

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

@ppkarwasz
Copy link
Contributor

The PR looks nice, but I need some time to analyze the existing code to see if we can reuse something. WatchManager looks reusable, but it works in a complex way.

@vy
Copy link
Member

vy commented Feb 12, 2025

Instead of a fully-blown event bus that is publicly exposed, can we make this private and as small as possible, please? I agree with @ppkarwasz that we shall seek to use existing file watching mechanisms available, if possible.

@vy vy added enhancement Additions or updates to features appenders Affects one or more Appender plugins labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appenders Affects one or more Appender plugins enhancement Additions or updates to features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants