Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading of the effective RecyclerFactoryConverter #3398

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Fix loading of the effective RecyclerFactoryConverter #3398

merged 2 commits into from
Jan 27, 2025

Conversation

vy
Copy link
Member

@vy vy commented Jan 15, 2025

Fixes #3395.

@vy vy added bug Incorrect, unexpected, or unintended behavior of existing code layouts Affects one or more Layout plugins labels Jan 15, 2025
@vy vy added this to the 2.25.0 milestone Jan 15, 2025
@vy vy requested a review from ppkarwasz January 15, 2025 14:41
@vy vy self-assigned this Jan 15, 2025
@vy vy mentioned this pull request Jan 17, 2025
Closed
ppkarwasz
ppkarwasz approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

So you eliminated the RecyclerFactories static registry and reused the type converter registry? Can you mark RecyclerFactories as deprecated?

@vy
Copy link
Member Author

vy commented Jan 24, 2025

So you eliminated the RecyclerFactories static registry and reused the type converter registry? Can you mark RecyclerFactories as deprecated?

Good catch. Fixed in 6f216f9.

@vy vy merged commit f5c6d73 into 2.x Jan 27, 2025
9 checks passed
@vy vy deleted the fix/2.x/JTL-RecyclerFactoryConverter branch January 27, 2025 09:53
@ppkarwasz
Copy link
Contributor

@vy, could you port it to main or add it to the backlog (#3161)?

@vy
Copy link
Member Author

vy commented Jan 27, 2025 •
edited
Loading

@vy, could you port it to main or add it to the backlog (#3161)?

Recyclers are wired in a totally different way in main; they are in log4j-kit, wired using ServiceLoaders, etc. I don't think this PR makes sense there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppkarwasz ppkarwasz ppkarwasz approved these changes

Assignees

@vy vy

Labels
bug Incorrect, unexpected, or unintended behavior of existing code layouts Affects one or more Layout plugins
Projects
None yet
Milestone
2.25.0
Development

Successfully merging this pull request may close these issues.

JsonTemplateLayout: Cannot replace recycler factory, template always uses standard factory
2 participants
@vy @ppkarwasz