-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve configuration error handling of HttpAppender #3438
Conversation
There are formatting errors in your PR. Run:
to fix them. |
@ppkarwasz |
We have two style rules for the code:
I'll look at your PR in the weekend. |
Yeah I just realized that when i ran |
@ppkarwasz gentle ping! Could you please take a look :) Thank you! |
...-core-test/src/test/java/org/apache/logging/log4j/core/appender/HttpAppenderBuilderTest.java
Outdated
Show resolved
Hide resolved
Fixes #3011 |
Thank you for your contribution. |
This PR introduces improvements to HttpAppender and adds a new test class, HttpAppenderBuilderTest, to enhance test coverage. The changes include:
Updating HttpAppender.java to improve logging behavior.
Adding HttpAppenderBuilderTest.java to verify the builder logic for HttpAppender.
Ensuring that missing configurations (e.g., URL, Layout) correctly log errors.
Fixes #3011
Checklist
2.x
branch if you are targeting Log4j 2; usemain
otherwise./mvnw verify
succeeds (if it fails due to code formatting issues reported by Spotless, simply run./mvnw spotless:apply
and retry)src/changelog/.2.x.x
directory