Only set default configuration name if none has been previously set (… #3454
+105
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
reviewed
Feb 16, 2025
| // LOG4J2-1176 facilitate memory leak investigation | ||
| setName(DefaultConfiguration.DEFAULT_NAME + "@" + Integer.toHexString(hashCode())); | ||
| // LOG4J2-3431 don't set a default name if one has already been set | ||
| if (this.getName() == null || this.getName().trim().isEmpty()) { |
There was a problem hiding this comment.
We have a Strings.isEmpty utility method for this.
There was a problem hiding this comment.
@ppkarwasz should I update the PR?
There was a problem hiding this comment.
@ppkarwasz - Fixed and moved changelog file as mentioned in other PR.
…pache#3431) + moved changelog file to .2.x.x
Generated by gradle/develocity-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#3431]
AbstractConfiguration#setToDefault() - only sets default configuration name if none has been previously set,