Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of null 'replacement' parameter in RegexReplacement#createRegexReplacement #3457

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

JWT007
Copy link
Contributor

@JWT007 JWT007 commented Feb 11, 2025

[#3215]

Returns null if the 'replacement' parameter is null.

  • per other builder methods in Log4j a invalid input parameter should result in a fast-fail returning null
  • added changelog for 2.25.0

…eateRegexReplacement (apache#3215)

* per other builder methods in Log4j a invalid input parameter should result in a fas-fail returning null
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

@JWT007
Copy link
Contributor Author

JWT007 commented Feb 16, 2025

@ppkarwasz - moved changelog to .2.x.x per otther code-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants