Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validation for AsyncWaitStrategyFactoryConfig for null/empty 'factoryClassName'. (#3159) #3462

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from
Open

Improve validation for AsyncWaitStrategyFactoryConfig for null/empty 'factoryClassName'. (#3159) #3462

wants to merge 3 commits into from

Conversation

JWT007
Copy link
Contributor

@JWT007 JWT007 commented Feb 12, 2025

(#3159)

This should fix a potential NPE in AsyncWaitStrategyFactoryConfig if the builder 'class' field is not set or set to null/empty string.

  • added notEmpty assert to Builder setFactoryClassName
  • changed notNull to notEmpty assert to AsyncWaitStrategyFactoryConfig constructor.
  • added changelog XML file. (2.25.0)
  • added new tests to AsyncWaitStrategyFactoryConfigTest

@ppkarwasz ppkarwasz linked an issue Feb 16, 2025 that may be closed by this pull request
AsyncWaitStrategyFactoryConfig - potential NPE when creating programatically #3159
Open
@JWT007
Copy link
Contributor Author

JWT007 commented Feb 16, 2025

@ppkarwasz moved changelog to .2.x.x per other PR notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncWaitStrategyFactoryConfig - potential NPE when creating programatically
2 participants
@JWT007 @jethomas-tsi