Fix shutdownDisable not taking effect(#2614) #3508
Open
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by gradle/develocity-actions |
Closed
vy
requested changes
Mar 14, 2025
There was a problem hiding this comment.
@Pluto-syd, thanks so much for the fix! Would you mind adding a changelog entry file too, please?
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java
Outdated
Show resolved
Hide resolved
ppkarwasz
approved these changes
Mar 14, 2025
log4j-core-test/src/test/java/org/apache/logging/log4j/core/ShutdownDisabledTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Piotr P. Karwasz <piotr@github.copernik.eu>
vy
reviewed
Mar 14, 2025
|
This PR need to be merged with |
I looked at why CI didn't pass, and made some changes to the way the log4j-spring-boot module reloaded the configuration to pass CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix shutdownDisable not taking effect(#2614)