-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-14375 - Kafka refactor - partitioning, uncommitted time, inputstream, tests, etc #9807
base: main
Are you sure you want to change the base?
Conversation
…ream, tests, etc Signed-off-by: Pierre Villard <[email protected]>
Signed-off-by: Pierre Villard <[email protected]>
...undle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/ConsumeKafka.java
Show resolved
Hide resolved
...ava/org/apache/nifi/kafka/processors/consumer/convert/RecordStreamKafkaMessageConverter.java
Show resolved
Hide resolved
...kafka-3-integration/src/test/java/org/apache/nifi/kafka/processors/ConsumeKafkaRecordIT.java
Outdated
Show resolved
Hide resolved
...a-3-integration/src/test/java/org/apache/nifi/kafka/processors/PublishKafkaRoundRobinIT.java
Outdated
Show resolved
Hide resolved
...ka-3-service/src/main/java/org/apache/nifi/kafka/service/consumer/Kafka3ConsumerService.java
Show resolved
Hide resolved
...fka-3-service/src/test/java/org/apache/nifi/kafka/service/Kafka3ConnectionServiceBaseIT.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/apache/nifi/kafka/processors/producer/convert/KafkaRecordConverterTest.java
Outdated
Show resolved
Hide resolved
Thanks for the review @dan-s1 - I've addressed some of your comments. I didn't apply some recommended changes as I'm not sure this would improve readability / performances. For the parameterized tests, I'm open to the idea but could not find a nice way to make it work with the runner, if you have a working approach, I'm ok with it :) |
Take a look at #9785 where there is an example of one. |
Thanks @dan-s1 - managed to get something working - not sure it makes things easier to understand for a few lines of code gain :) |
Summary
NIFI-14375 - Kafka refactor - partitioning, uncommitted time, inputstream, tests, etc
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation