Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14375 - Kafka refactor - partitioning, uncommitted time, inputstream, tests, etc #9807

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pvillard31
Copy link
Contributor

Summary

NIFI-14375 - Kafka refactor - partitioning, uncommitted time, inputstream, tests, etc

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@pvillard31
Copy link
Contributor Author

Thanks for the review @dan-s1 - I've addressed some of your comments. I didn't apply some recommended changes as I'm not sure this would improve readability / performances. For the parameterized tests, I'm open to the idea but could not find a nice way to make it work with the runner, if you have a working approach, I'm ok with it :)

@dan-s1
Copy link
Contributor

dan-s1 commented Mar 17, 2025

Take a look at #9785 where there is an example of one.

@pvillard31
Copy link
Contributor Author

Thanks @dan-s1 - managed to get something working - not sure it makes things easier to understand for a few lines of code gain :)

@pvillard31
Copy link
Contributor Author

Note to reviewers: I just added a commit (c40cde6) that properly handles KIP-794 which changes the approach for the default partitioning. This change is required in anticipation of bumping the Kafka client to 4.0.0 where the class is completely removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants