Security #590
Security #590
Conversation
The spark security page already links to the Apache-wide security information. This change removes the link from the menu to the Apache-wide security page, making it more likely people will discover the Spark-specific one first. Also link from the Spark-specific security page to the security page in the docs. See also https://cwiki.apache.org/confluence/display/SECURITY/Documenting+your+security+model
There was a problem hiding this comment.
Oh actually it looks like the generated HTML has some differences and the CI/CD checks fail. Can you check if your jekyll version, etc is the same? see the notes on https://github.com/apache/spark-website
(though these kinda seem unrelated to the changes to the source?)
ah I ignored some changes that seemed unrelated... now committed those as well |
| @@ -147,7 +147,6 @@ | |||
| <li><a class="dropdown-item" | |||
| href="https://www.apache.org/foundation/sponsorship.html">Sponsorship</a></li> | |||
| <li><a class="dropdown-item" href="https://www.apache.org/foundation/thanks.html">Thanks</a></li> | |||
| <li><a class="dropdown-item" href="https://www.apache.org/security/">Security</a></li> | |||
There was a problem hiding this comment.
Instead of removing this, please update it with the project-specific one and match the regex ^https?://.*apache.org/.*[Ss]ecurity to satisfy ASF requirements
There was a problem hiding this comment.
I think the point is that there is already a "Security" link in the Developer menu that points to the Spark Security page.
There was a problem hiding this comment.
I mean we can replace this with our security side to reach the goal of this PR and satisfy the ASF website check service
| @@ -152,7 +152,6 @@ | |||
| <li><a class="dropdown-item" | |||
| href="https://www.apache.org/foundation/sponsorship.html">Sponsorship</a></li> | |||
| <li><a class="dropdown-item" href="https://www.apache.org/foundation/thanks.html">Thanks</a></li> | |||
| <li><a class="dropdown-item" href="https://www.apache.org/security/">Security</a></li> | |||
The spark security page already links to the Apache-wide security information. This change removes the link from the menu to the Apache-wide security page, making it more likely people will discover the Spark-specific one first.
Also adds a link from the Spark-specific security page to the security page in the docs.
See also https://cwiki.apache.org/confluence/display/SECURITY/Documenting+your+security+model