Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minikube e2e testing #273

Closed
wants to merge 3 commits into from
Closed

Minikube e2e testing #273

wants to merge 3 commits into from

Conversation

halim-lee
Copy link
Collaborator

What this PR does / why we need it?:

  • Support e2e testing for Minikube

Does this PR introduce a user-facing change?

  • User guide
  • CHANGELOG.md

Which issue(s) this PR fixes:

Fixes #235

@halim-lee halim-lee requested a review from leochr November 23, 2021 14:59
@halim-lee
Copy link
Collaborator Author

halim-lee commented Nov 23, 2021

Ingress addon requires drivers to be something else other than "none" - the driver is docker by default. This requires a non-root user.

This PR uses Ian's deploy/kustomize/daily/base/runtime-component-operator.yaml from his PR: #256

For probe test, it runs successfully through kubectl kuttl test ... but it fails when it's run through operator-sdk command. I removed 02-errors.yaml and it runs successfully... This seems like kuttl's problem.
Storage tests are all running successfully. For now, stream and knative tests are not supported.

Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halim-lee Thanks for the PR. Looks good. Since the majority of the tests are the same between ocp and minikube, it'll be good to add script to copy the existing tests, remove the ones that are not needed for minikube (i.e. route) and then add the tests for minikube (ingress).

labels:
app.kubernetes.io/instance: probes-rc
name: probes-rc
spec:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment resource and the .spec fields are duplicated in all the modified files.

status:
readyReplicas: 1
---
apiVersion: extensions/v1beta1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator generates ingress with apiVersion networking.k8s.io/v1
Is this minikube specific?

Copy link
Collaborator Author

@halim-lee halim-lee Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. apiVersion: extensions/v1beta1 is what gets created in the Minikube cluster when expose is set to True. Minikube lists both networking.k8s.io/v1 and extensions/v1beta1 as supported. Not sure why the beta version is selected...


mkdir -p $HOME/.kube $HOME/.minikube
touch $KUBECONFIG
sudo minikube start --profile=minikube --vm-driver=none --kubernetes-version=v1.18.1
minikube start --profile=minikube --kubernetes-version=v1.20.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use kubectl 1.19 since OpenShift 4.6 (Long supported version) is at that level.

@halim-lee halim-lee closed this Nov 24, 2021
@halim-lee halim-lee mentioned this pull request Nov 24, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automation to run the e2e tests on minikube
2 participants