Added the support for GR1CS and added rescue hash function #161
+2,006
−1,002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
requested changes
Mar 20, 2025
| assert!(cs.is_satisfied().unwrap()); | ||
| } | ||
| } | ||
| // #[cfg(test)] |
| let _ = TestCRHGadget::evaluate(¶meters_var, &input_var).unwrap(); | ||
| } | ||
| } | ||
| // #[cfg(test)] |
| @@ -10,7 +10,7 @@ use ark_serialize::{CanonicalDeserialize, CanonicalSerialize}; | |||
| #[cfg(not(feature = "std"))] | |||
| use ark_std::vec::Vec; | |||
| use ark_std::{borrow::Borrow, fmt::Debug, hash::Hash, marker::PhantomData, rand::Rng}; | |||
| #[cfg(feature = "r1cs")] | |||
| #[cfg(any(feature = "r1cs", feature = "gr1cs"))] | |||
There was a problem hiding this comment.
We shouldn't have two features, just use gr1cs.
| assert!(cs.is_satisfied().unwrap()); | ||
| } | ||
| } | ||
| // #[cfg(test)] |
| mod test { | ||
| use crate::encryption::constraints::AsymmetricEncryptionGadget; | ||
| use ark_std::{test_rng, UniformRand}; | ||
| // #[cfg(test)] |
| state: &mut [FpVar<F>], | ||
| exponent: &[u64], | ||
| alpha: u64, | ||
| // round: usize |
| FpVar::new_witness(self.cs(), || Ok(state_item.value()?.pow(exponent))) | ||
| .unwrap(); | ||
| match (&state_item, &new_state_item) { | ||
| (FpVar::Var(alloc_fp), FpVar::Var(new_alloc_fp)) => { |
There was a problem hiding this comment.
Maybe change to use is_constant()?
Comment on lines
+160
to
+207
| loop { | ||
| // if we can finish in this call | ||
| if rate_start_index + remaining_elements.len() <= self.parameters.rate { | ||
| for (i, element) in remaining_elements.iter().enumerate() { | ||
| self.state[self.parameters.capacity + i + rate_start_index] += element; | ||
| } | ||
| self.mode = DuplexSpongeMode::Absorbing { | ||
| next_absorb_index: rate_start_index + remaining_elements.len(), | ||
| }; | ||
|
|
||
| return Ok(()); | ||
| } | ||
| // otherwise absorb (rate - rate_start_index) elements | ||
| let num_elements_absorbed = self.parameters.rate - rate_start_index; | ||
| for (i, element) in remaining_elements | ||
| .iter() | ||
| .enumerate() | ||
| .take(num_elements_absorbed) | ||
| { | ||
| self.state[self.parameters.capacity + i + rate_start_index] += element; | ||
| } | ||
| self.permute()?; | ||
| // the input elements got truncated by num elements absorbed | ||
| remaining_elements = &remaining_elements[num_elements_absorbed..]; | ||
| rate_start_index = 0; | ||
| } | ||
| } | ||
|
|
||
| // Squeeze |output| many elements. This does not end in a squeeze | ||
| fn squeeze_internal( | ||
| &mut self, | ||
| mut rate_start_index: usize, | ||
| output: &mut [FpVar<F>], | ||
| ) -> Result<(), SynthesisError> { | ||
| let mut remaining_output = output; | ||
| loop { | ||
| // if we can finish in this call | ||
| if rate_start_index + remaining_output.len() <= self.parameters.rate { | ||
| remaining_output.clone_from_slice( | ||
| &self.state[self.parameters.capacity + rate_start_index | ||
| ..(self.parameters.capacity + remaining_output.len() + rate_start_index)], | ||
| ); | ||
| self.mode = DuplexSpongeMode::Squeezing { | ||
| next_squeeze_index: rate_start_index + remaining_output.len(), | ||
| }; | ||
| return Ok(()); | ||
| } | ||
| // otherwise squeeze (rate - rate_start_index) elements |
There was a problem hiding this comment.
Update to match updated Poseidon implementation
| } | ||
|
|
||
| #[cfg(feature = "r1cs")] | ||
| fn apply_s_box( |
There was a problem hiding this comment.
Add tracing instrumentation everywhere.
|
|
||
| impl<F: PrimeField> RescueConfig<F> { | ||
| /// Initialize the parameter for Rescue Sponge. | ||
| pub fn new( |
There was a problem hiding this comment.
Update the Rescue sponge impl to match changed Poseidon impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer