-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ DO NOT MERGE YET | Add support for Federated Connection Access Token #1924
Draft
nandan-bhat
wants to merge
7
commits into
main
Choose a base branch
from
feat/federated-connection-token
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tushar Pandey <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1924 +/- ##
==========================================
- Coverage 74.69% 72.64% -2.05%
==========================================
Files 19 19
Lines 1379 1601 +222
Branches 210 232 +22
==========================================
+ Hits 1030 1163 +133
- Misses 342 431 +89
Partials 7 7 ☔ View full report in Codecov by Sentry. |
10510b2
to
b1c5095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR adds support for
getFederatedConnectionAccessToken({ connection: string; login_hint?: string })
, which can be used to obtain federated connection access token using theoauth/token
endpoint.In order to retrieve a federated connection access token, we call
oauth/token
using the following payload:The retrieved token will also be stored in the session store, comparable to regular session information.
Stateless
As the browser has a limit to the size of the cookie, each federated connection access token is stored in its own cookie, using the
__FC_{index}
name.When an application needs to us many access tokens, it's recommended to consider using a stateful session store.
Stateful
For the stateful session store, nothing changes other than the fact that the provided
SessionData
, now has an additionalfederatedConnectionTokenSets
property, being either undefined, or an array ofFederatedConnectionTokenSet
.Just like
getAccessToken()
, the newly addedgetFederatedConnectionAccessToken()
can not write to the cookies when called from a Server Component, and will log awarning
when either of these two methods are called from such Server Component.📎 References
N/A
🎯 Testing
I have tested this against the only environment that has the feature enabled, and I ensured the following scenario's:
getFederatedConnectionAccessToken
throws theMISSING_REFRESH_TOKEN
error.oauth/token
is mad, the resulting access token is stored in the stateless or stateful session store and returned.oauth/token
is made, and the access token from the cache is returned.oauth/token
is mad, the resulting access token is stored in the stateless or stateful session store and returned.__FC
cookies are also removed.