Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not hard-code arch to amd64 #527

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: do not hard-code arch to amd64 #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36938a7
fix: do not hard-code arch to amd64
razor-1 Apr 27, 2024
ba61452
fix: do not hard-code arch to amd64 in Dockerfile.local
razor-1 Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ARG golang_version
FROM $builder_image:$golang_version as builder

ARG service_alias
ARG target_arch=amd64
ARG TARGETARCH
# The tuple of controller image version information
ARG service_controller_git_version
ARG service_controller_git_commit
Expand All @@ -22,7 +22,7 @@ ARG work_dir=/github.com/aws-controllers-k8s/$service_alias-controller
WORKDIR $work_dir
ENV GOPROXY=https://proxy.golang.org|direct
ENV GO111MODULE=on
ENV GOARCH=$target_arch
ENV GOARCH=$TARGETARCH
ENV GOOS=linux
ENV CGO_ENABLED=0
ENV VERSION_PKG=github.com/aws-controllers-k8s/$service_alias-controller/pkg/version
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.local
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ ARG service_alias
ARG service_controller_git_version
ARG service_controller_git_commit
ARG build_date
ARG target_arch=amd64
ARG TARGETARCH
# The directory within the builder container into which we will copy our
# service controller code.
ARG work_dir=/github.com/aws-controllers-k8s/$service_alias-controller
WORKDIR $work_dir
ENV GOPROXY=https://proxy.golang.org|direct
ENV GO111MODULE=on
ENV GOARCH=$target_arch
ENV GOARCH=$TARGETARCH
ENV GOOS=linux
ENV CGO_ENABLED=0
ENV VERSION_PKG=github.com/aws-controllers-k8s/$service_alias-controller/pkg/version
Expand Down