Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for aws-sdk-go-v2 #555

Open
wants to merge 4 commits into
base: aws-sdk-go-v2
Choose a base branch
from

Conversation

rkurduka
Copy link

Issue #, if available:

Description of changes:

Changes are require to migrate code-generator from AWS SDK GO V1 to V2

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from a-hilaly October 16, 2024 03:58
Copy link

ack-prow bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rkurduka
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested a review from jlbutler October 16, 2024 03:58
@michaelhtm michaelhtm force-pushed the aws-sdk-go-v2 branch 4 times, most recently from 7f9f2ab to 6a91bd1 Compare January 8, 2025 17:38
Copy link

ack-prow bot commented Jan 11, 2025

@rkurduka: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 47e8343 link false /test verify-attribution
s3-olm-test 47e8343 link false /test s3-olm-test
unit-test 47e8343 link true /test unit-test
iam-controller-test 47e8343 link true /test iam-controller-test
acm-controller-test 47e8343 link true /test acm-controller-test
eks-controller-test 47e8343 link true /test eks-controller-test
ec2-controller-test 47e8343 link true /test ec2-controller-test
pipes-controller-test 47e8343 link true /test pipes-controller-test
prometheusservice-controller-test 47e8343 link true /test prometheusservice-controller-test
cloudfront-controller-test 47e8343 link true /test cloudfront-controller-test
apigatewayv2-controller-test 47e8343 link true /test apigatewayv2-controller-test
eventbridge-controller-test 47e8343 link true /test eventbridge-controller-test
efs-controller-test 47e8343 link true /test efs-controller-test
documentdb-controller-test 47e8343 link true /test documentdb-controller-test
dynamodb-controller-test 47e8343 link true /test dynamodb-controller-test
lambda-controller-test 47e8343 link true /test lambda-controller-test
ecr-controller-test 47e8343 link true /test ecr-controller-test
s3-controller-test 47e8343 link true /test s3-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants