-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom shapes using simplified schema #574
Conversation
/retest |
/test s3-controller-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Arush!
acb83c3
to
252cd20
Compare
21915b0
to
82298d8
Compare
82298d8
to
afd027d
Compare
bfac339
to
05971ba
Compare
05971ba
to
31e0e59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot Arush!! Getting very close - a few minor comments:
pkg/testdata/models/apis/dynamodb/0000-00-00/generator-with-custom-shapes.yaml
Outdated
Show resolved
Hide resolved
238c905
to
f582110
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome works on this @rushmash91 ! thanks a lot for the quick updates :)
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test eks-controller-test |
@rushmash91: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description of changes:
CustomShapes
field to the Config struct to store user-defined custom shapesInjectSimpleSchemaShapes
function that processes custom shapes and injects them into the SDK API modelgithub.com/kro-run/kro
package for schema handlingBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.