Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom shapes using simplified schema #574

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

rushmash91
Copy link
Member

Description of changes:

  • Added CustomShapes field to the Config struct to store user-defined custom shapes
  • Implemented InjectSimpleSchemaShapes function that processes custom shapes and injects them into the SDK API model
  • Added dependency on github.com/kro-run/kro package for schema handling

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler March 18, 2025 01:56
@rushmash91 rushmash91 changed the title add simpleschema Add support for custom shapes using simplified schema implementation Mar 18, 2025
@rushmash91 rushmash91 changed the title Add support for custom shapes using simplified schema implementation Add support for custom shapes using simplified schema Mar 18, 2025
@rushmash91
Copy link
Member Author

/retest

@rushmash91
Copy link
Member Author

/test s3-controller-test

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Arush!

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot Arush!! Getting very close - a few minor comments:

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome works on this @rushmash91 ! thanks a lot for the quick updates :)
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2025
Copy link

ack-prow bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Mar 20, 2025
@a-hilaly
Copy link
Member

/retest

@rushmash91
Copy link
Member Author

/test eks-controller-test

Copy link

ack-prow bot commented Mar 20, 2025

@rushmash91: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution f582110 link false /test verify-attribution
s3-olm-test f582110 link false /test s3-olm-test
apigatewayv2-controller-test f582110 link true /test apigatewayv2-controller-test
ec2-controller-test f582110 link true /test ec2-controller-test
efs-controller-test f582110 link true /test efs-controller-test
eks-controller-test f582110 link true /test eks-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rushmash91 rushmash91 merged commit 3722729 into aws-controllers-k8s:main Mar 20, 2025
12 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants