Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.40.0, code-generator v0.40.0 #15

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Dec 9, 2024

Update to ACK runtime v0.40.0, code-generator v0.40.0



stdout for make build-controller:

building ack-generate ... ok.
==== building cognitoidentity-controller ====
Copying common custom resource definitions into cognitoidentity
Building Kubernetes API objects for cognitoidentity
Generating deepcopy code for cognitoidentity
Generating custom resource definitions for cognitoidentity
Building service controller for cognitoidentity
Generating RBAC manifests for cognitoidentity
Running gofmt against generated code for cognitoidentity
Updating additional GitHub repository maintenance files
==== building cognitoidentity-controller release artifacts ====
Building release artifacts for cognitoidentity-v0.0.0-non-release-version
Generating common custom resource definitions
Generating custom resource definitions for cognitoidentity
Generating RBAC manifests for cognitoidentity

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Dec 9, 2024
@ack-prow ack-prow bot requested review from a-hilaly and jaypipes December 9, 2024 17:34
Copy link

ack-prow bot commented Dec 9, 2024

@ack-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
cognitoidentity-kind-e2e 8c238b2 link true /test cognitoidentity-kind-e2e
cognitoidentity-verify-attribution 8c238b2 link false /test cognitoidentity-verify-attribution
cognitoidentity-metadata-file-test 8c238b2 link true /test cognitoidentity-metadata-file-test
cognitoidentity-recommended-policy-test 8c238b2 link true /test cognitoidentity-recommended-policy-test
cognitoidentity-release-test 8c238b2 link true /test cognitoidentity-release-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
Copy link

ack-prow bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly a-hilaly merged commit ecd3d8a into main Jan 15, 2025
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants