Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ChangeBatch from spec #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove ChangeBatch from spec #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2025-03-14T20:40:51Z"
build_date: "2025-03-14T21:17:11Z"
build_hash: 0ab258c51775fd52af32e649da00d57373b20869
go_version: go1.24.0
version: v0.43.2-6-g0ab258c
api_directory_checksum: b920521646bacef1fba9d0b97a423d11565c7a60
api_directory_checksum: 72b15cdf04da5bbe0694a4a7d2987838696709a5
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
generator_config_info:
file_checksum: cb391b9a34945fd5dd28af68abd902a68d209e93
file_checksum: 96f2535415c83b5c233f78afa95088a0288c634c
original_file_name: generator.yaml
last_modification:
reason: API generation
53 changes: 27 additions & 26 deletions apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ ignore:
- CreateHostedZoneInput.CallerReference
- CreateHealthCheckInput.CallerReference
- ResourceRecordSet.GeoProximityLocation
- ChangeResourceRecordSetsInput.ChangeBatch
operations: null
resource_names:
- CidrCollection
Expand Down Expand Up @@ -54,27 +55,27 @@ resources:
fields:
AliasTarget:
from:
operation: ChangeResourceRecordSets
path: ChangeBatch.Changes.ResourceRecordSet.AliasTarget
operation: ListResourceRecordSets
path: ResourceRecordSets.AliasTarget
# This field cannot be ignored, but values for this will be overriden and should not be used
ChangeBatch:
is_required: false
CidrRoutingConfig:
from:
operation: ChangeResourceRecordSets
path: ChangeBatch.Changes.ResourceRecordSet.CidrRoutingConfig
operation: ListResourceRecordSets
path: ResourceRecordSets.CidrRoutingConfig
Failover:
from:
operation: ChangeResourceRecordSets
path: ChangeBatch.Changes.ResourceRecordSet.Failover
operation: ListResourceRecordSets
path: ResourceRecordSets.Failover
GeoLocation:
from:
operation: ChangeResourceRecordSets
path: ChangeBatch.Changes.ResourceRecordSet.GeoLocation
operation: ListResourceRecordSets
path: ResourceRecordSets.GeoLocation
HealthCheckId:
from:
operation: ChangeResourceRecordSets
path: ChangeBatch.Changes.ResourceRecordSet.HealthCheckId
operation: ListResourceRecordSets
path: ResourceRecordSets.HealthCheckId
# Changing this value after a CR has been created could result in orphaned record sets
HostedZoneId:
references:
Expand All @@ -88,48 +89,48 @@ resources:
ChangeResourceRecordSet request"
MultiValueAnswer:
from:
operation: ChangeResourceRecordSets
path: ChangeBatch.Changes.ResourceRecordSet.MultiValueAnswer
operation: ListResourceRecordSets
path: ResourceRecordSets.MultiValueAnswer
# Changing this value after a CR has been created could result in orphaned record sets.
# Note that the name refers to the subdomain value of a record set and not the fully
# qualified DNS name
Name:
from:
operation: ChangeResourceRecordSets
path: ChangeBatch.Changes.ResourceRecordSet.Name
operation: ListResourceRecordSets
path: ResourceRecordSets.Name
is_immutable: true
# Changing this value after a CR has been created could result in orphaned record sets
RecordType:
from:
operation: ChangeResourceRecordSets
path: ChangeBatch.Changes.ResourceRecordSet.Type
operation: ListResourceRecordSets
path: ResourceRecordSets.Type
is_required: true
is_immutable: true
Region:
from:
operation: ChangeResourceRecordSets
path: ChangeBatch.Changes.ResourceRecordSet.Region
operation: ListResourceRecordSets
path: ResourceRecordSets.Region
ResourceRecords:
from:
operation: ChangeResourceRecordSets
path: ChangeBatch.Changes.ResourceRecordSet.ResourceRecords
operation: ListResourceRecordSets
path: ResourceRecordSets.ResourceRecords
# Changing this value after a CR has been created could result in orphaned record sets
SetIdentifier:
from:
operation: ChangeResourceRecordSets
path: ChangeBatch.Changes.ResourceRecordSet.SetIdentifier
operation: ListResourceRecordSets
path: ResourceRecordSets.SetIdentifier
is_immutable: true
Status:
print:
name: STATUS
TTL:
from:
operation: ChangeResourceRecordSets
path: ChangeBatch.Changes.ResourceRecordSet.TTL
operation: ListResourceRecordSets
path: ResourceRecordSets.TTL
Weight:
from:
operation: ChangeResourceRecordSets
path: ChangeBatch.Changes.ResourceRecordSet.Weight
operation: ListResourceRecordSets
path: ResourceRecordSets.Weight
hooks:
sdk_create_post_build_request:
template_path: hooks/record_set/sdk_create_post_build_request.go.tpl
Expand Down
4 changes: 1 addition & 3 deletions apis/v1alpha1/record_set.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions apis/v1alpha1/types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 0 additions & 21 deletions apis/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

96 changes: 0 additions & 96 deletions config/crd/bases/route53.services.k8s.aws_recordsets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,102 +66,6 @@ spec:
hostedZoneID:
type: string
type: object
changeBatch:
description: A complex type that contains an optional comment and
the Changes element.
properties:
changes:
items:
description: The information for each resource record set that
you want to change.
properties:
action:
type: string
resourceRecordSet:
description: Information about the resource record set to
create or delete.
properties:
aliasTarget:
description: |-
Alias resource record sets only: Information about the Amazon Web Services
resource, such as a CloudFront distribution or an Amazon S3 bucket, that
you want to route traffic to.

When creating resource record sets for a private hosted zone, note the following:

* For information about creating failover resource record sets in a private
hosted zone, see Configuring Failover in a Private Hosted Zone (https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/dns-failover-private-hosted-zones.html).
properties:
dnsName:
type: string
evaluateTargetHealth:
type: boolean
hostedZoneID:
type: string
type: object
cidrRoutingConfig:
description: |-
The object that is specified in resource record set object when you are linking
a resource record set to a CIDR location.

A LocationName with an asterisk “*” can be used to create a default CIDR
record. CollectionId is still required for default record.
properties:
collectionID:
type: string
locationName:
type: string
type: object
failover:
type: string
geoLocation:
description: A complex type that contains information
about a geographic location.
properties:
continentCode:
type: string
countryCode:
type: string
subdivisionCode:
type: string
type: object
healthCheckID:
type: string
multiValueAnswer:
type: boolean
name:
type: string
region:
type: string
resourceRecords:
items:
description: |-
Information specific to the resource record.

If you're creating an alias resource record set, omit ResourceRecord.
properties:
value:
type: string
type: object
type: array
setIdentifier:
type: string
trafficPolicyInstanceID:
type: string
ttl:
format: int64
type: integer
type_:
type: string
weight:
format: int64
type: integer
type: object
type: object
type: array
comment:
type: string
type: object
cidrRoutingConfig:
description: |-
The object that is specified in resource record set object when you are linking
Expand Down
Loading