-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logging): Extract and store arbitrary values from the request #817
base: develop
Are you sure you want to change the base?
feat(logging): Extract and store arbitrary values from the request #817
Conversation
chore(ci): merging dev to main
chore(ci): merging dev to main
chore(ci): Adding additional maintenace fixes to main
chore: Sync main with develop
chore(ci): merge develop to main for NuGet references for examples update
chore: Sync main with develop
chore: Sync main with develop
chore: Sync main with develop
chore: Sync main with develop
chore: Sync main with develop for release 1.4.1
chore: Sync main with develop for release 1.4.2
chore: update nuget examples
chore: Sync develop to main
chore: Sync develop to main
chore: Sync develop to main
chore: Sync develop to main for release
chore: Sync develop to main post release
chore: Sync main with develop for release 1.8.1
chore: Sync main - develop - Update examples
chore: Sync main from develop
chore: Sync Main with Develop release 1.13
chore: Sync main with develop for release 1.13
chore: sync main with dev for release 1.13
chore: Sync main and develop for release 1.13
chore: Sync main with develop for release 1.14
chore: Sync main with develop for relase 1.14
chore: Sync main with develop for release
chore: Sync main with Master for Tracing fix
chore: Sync main with develop for release to fix metrics output
chore: Sync main with develop for release 1.16
chore: Sync main with develop for release 1.17
chore: Sync main with develop for release 1.18
chore: Sync main with develop for release 1.18
chore: Sync main with develop for release 1.19
chore: sync main with develop for release 1.19
chore: Sync main with develop for release 1.20
chore: Sync main with develop
chore: Sync main with develop
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #817 +/- ##
===========================================
- Coverage 74.15% 74.12% -0.03%
===========================================
Files 210 210
Lines 8411 8425 +14
Branches 909 911 +2
===========================================
+ Hits 6237 6245 +8
- Misses 1881 1886 +5
- Partials 293 294 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issue number: #816
Summary
Can now easily extract arbitrary values from the request and store as a logging key.
Changes
User experience
Before: You would have to write custom code that executes on every request to extract the fields from the header for example, and save it in the log key. This is less convenient than adding it to the existing Logging attribute.
After: Simply update the parameter in the Logging attribute and it will do this work for you:
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change? NO
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.