Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(layers): add workflows for govcloud layers #3747

Merged
merged 7 commits into from
Mar 21, 2025

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Mar 19, 2025

Summary

Changes

Please provide a summary of what's being changed

This PR adds two workflows to publish layers to govcloud. The documentation update will come in a separate PR.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3423


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Mar 19, 2025
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Mar 19, 2025
@am29d am29d requested a review from sthulb March 19, 2025 14:06
@am29d am29d self-assigned this Mar 19, 2025
@am29d am29d added the layers Items related to the Lambda Layers pipeline label Mar 19, 2025
@am29d am29d changed the title chore(layer): add workflows for govloud layers chore(layers): add workflows for govloud layers Mar 19, 2025
@dreamorosi dreamorosi self-requested a review March 19, 2025 14:35
sthulb
sthulb previously requested changes Mar 19, 2025
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two comments, one about docs and another about a missing permission.

I don't have a lot of context on what the workflow is supposed to do, and I haven't tested it so I assume the secrets and permissions needed by the workflows are already (or will be) in place.

Besides that, if possible, please update the sections here to make sure it's clear at which point of the release we need to run these workflows.

@am29d am29d changed the title chore(layers): add workflows for govloud layers chore(layers): add workflows for govcloud layers Mar 19, 2025
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Mar 19, 2025
@am29d
Copy link
Contributor Author

am29d commented Mar 20, 2025

Added the workflow trigger to the layer deployment pipeline and updated the maintainers doc diagram. The deployment numbers are estimated, I will change them once it has been deployed.

We still need to add readonly env for the prod, I don't want to pass write IAM to readonly workflow, @sthulb .

Before the next release we need to deploy and bump the versions once, like we do for new region deployments.

@am29d am29d requested review from dreamorosi and sthulb March 20, 2025 20:30
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both, if possible let's test the workflows in beta right after merging

@dreamorosi dreamorosi dismissed sthulb’s stale review March 21, 2025 11:11

Already approved offline

@dreamorosi dreamorosi merged commit 42f0cf4 into main Mar 21, 2025
43 checks passed
@dreamorosi dreamorosi deleted the issue3423/govcloud-layers branch March 21, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation documentation Improvements or additions to documentation layers Items related to the Lambda Layers pipeline size/L PRs between 100-499 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Make layer available in GovCloud
3 participants