-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(layers): add workflows for govcloud layers #3747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two comments, one about docs and another about a missing permission.
I don't have a lot of context on what the workflow is supposed to do, and I haven't tested it so I assume the secrets and permissions needed by the workflows are already (or will be) in place.
Besides that, if possible, please update the sections here to make sure it's clear at which point of the release we need to run these workflows.
|
Added the workflow trigger to the layer deployment pipeline and updated the maintainers doc diagram. The deployment numbers are estimated, I will change them once it has been deployed. We still need to add readonly env for the prod, I don't want to pass write IAM to readonly workflow, @sthulb . Before the next release we need to deploy and bump the versions once, like we do for new region deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both, if possible let's test the workflows in beta right after merging
Summary
Changes
This PR adds two workflows to publish layers to govcloud. The documentation update will come in a separate PR.
Issue number: closes #3423
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.