-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python 3.8 support #7908
base: develop
Are you sure you want to change the base?
Conversation
eca5325
to
5db51c6
Compare
5db51c6
to
0d4ef7e
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a samcli/lib/build/constants.py
file, with a list of deprecated runtimes, where we should add python3.8
. And the corresponding tests for that are in tests/unit/lib/build_module/test_app_builder.py
There's also a message in pytest.ini
that says that an ignore option (ignore::boto3.exceptions.PythonDeprecationWarning
) can be removed after we stop supporting python3.7, so we might want to get rid of that too
@@ -1,6 +1,6 @@ | |||
{ | |||
"project_name": "Name of the project", | |||
"runtime": "python3.8", | |||
"runtime": "python3.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably be good to update this to a newer version of python right away (python3.13
), because this is the default init template if people have problems downloading the full list of templates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Thanks
Remove python 3.8 support
Which issue(s) does this change fix?
Why is this change necessary?
Python 3.8 is deprecated
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.