fix: Prevent duplicated cdk-defined resource ids #7931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limiting aws:cdk:path metadata partitions length in order to prevent duplicated resource ids. Logical id will be used if it is not possible to ensure that the resource id extracted from aws:cdk:path is unique.
Which issue(s) does this change fix?
#4064
#4034
aws/aws-cdk#21134
Why is this change necessary?
SAM CLI extracts the resource id from aws:cdk:path metadata value when it is present.
This value is always unique when generated by CDK. However, only the second last partition is used, which might not be unique cross all resources in the stack.
How does it address the issue?
By limiting the usage of
aws:cdk:path
metadata when the number of partitions is bigger than 3.In these situations, it is not possible to ensure that the second last partition will be unique, and the logical id should be used instead.
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.