Feat allow dict values in generate event cmd #7938
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
I want to add the ability to override not only string values but also dictionary values in
sam local generate-event
. Currently, after running the CLI command, you have to manually adjust the file values.An example is
queryStringParameters
in API Gateway. This is not supported via the CLI command. When making basic modifications toevent-mapping.json
andapigateway/AwsProxy.json
to support the parameter, a string is returned, whereasqueryStringParameters
expects a dictionary.That's why I'm making changes to
generate_event
to check if a value is of type dict. If so, the string value will be replaced with a dictionary.I'm creating a draft PR to gather feedback and input on this feature and to see if it's considered a viable option (so I just added this for queryStringParams for API GW aws- proxy.
Test:
Output:
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.