-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java v2 Add S3 Express Scenario #7270
Conversation
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Show resolved
Hide resolved
Overall commentsAlways refer to "regular" buckets rather than "normal" buckets. Lowercase the "d" in "Directory buckets". README changes
Specification changes
I'm still reviewing .... |
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/CreateDirectoryBucket.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesActions.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesActions.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesActions.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesActions.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesActions.java
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesActions.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesActions.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesActions.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesActions.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesActions.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesActions.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesActions.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesActions.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/resources/s3_express_template.yaml
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/express/S3DirectoriesScenario.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done as much review as I have time for. Check out the comment with the "Overall Comments". It contains comments related to the README and Specification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scott and I went through the changes in our weekly meeting. Scott will send my concers regarding the VPC issue and IAM user creation to Jason.
I sent the feedback about Spec, etc to Jason. |
This pull request adds Java S3 Express Scenario
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.