Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate StreamIdentifier constructors that accept stream name or serialized identifier #1306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deprecate StreamIdentifier constructors that accept stream name or serialized identifier #1306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions amazon-kinesis-client/src/main/java/software/amazon/kinesis/common/StreamIdentifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,10 @@ public String toString() {
*
* @param streamIdentifierSer a String of {@code account:stream:creationEpoch}
* @return StreamIdentifier with {@link #accountIdOptional} and {@link #streamCreationEpochOptional} present
*
* @deprecated This method is deprecated. Please use {@link #multiStreamInstance(Arn, long)} instead.
*/
@Deprecated
public static StreamIdentifier multiStreamInstance(String streamIdentifierSer) {
final Matcher matcher = STREAM_IDENTIFIER_PATTERN.matcher(streamIdentifierSer);
if (matcher.matches()) {
Expand Down Expand Up @@ -142,7 +145,10 @@ public static StreamIdentifier multiStreamInstance(Arn streamArn, long creationE
* Create a single stream instance for StreamIdentifier from stream name.
*
* @param streamName stream name of a Kinesis stream
*
* @deprecated This method is deprecated. Please use {@link #singleStreamInstance(Arn)} instead.
*/
@Deprecated
public static StreamIdentifier singleStreamInstance(String streamName) {
Validate.notEmpty(streamName, "StreamName should not be empty");

Expand Down
Loading