Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects should be owned by schema owner in Babelfish #3560

Conversation

shalinilohia50
Copy link
Contributor

@shalinilohia50 shalinilohia50 commented Mar 9, 2025

Description

When a new object is created in Babelfish, its owner should be same as its schema owner.
Upgrade approach:

  1. Older objects will continue to have the owner (which can be different than the schema owner)
  2. There are functions provided to check the objects where there is owner mismatch between object and its schema. User can run the scripts and update the ownership themselves.

Issues Resolved

Task: BABEL-5361
Signed-off-by: Shalini Lohia [email protected]

Test Scenarios Covered

  • Use case based - Added
  • Boundary conditions -
  • Arbitrary inputs -
  • Negative test cases -
  • Minor version upgrade tests -
  • Major version upgrade tests -
  • Performance tests -
  • Tooling impact -
  • Client tests -

@coveralls
Copy link
Collaborator

coveralls commented Mar 9, 2025

Pull Request Test Coverage Report for Build 13929337773

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • 29 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.009%) to 74.933%

Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tsql/src/pltsql_utils.c 2 92.05%
contrib/babelfishpg_tsql/src/dbcmds.c 27 59.19%
Totals Coverage Status
Change from base Build 13928900957: -0.009%
Covered Lines: 47363
Relevant Lines: 63207

💛 - Coveralls

@shardgupta shardgupta merged commit d35674f into babelfish-for-postgresql:BABEL_4_X_DEV Mar 20, 2025
48 checks passed
@shardgupta shardgupta deleted the jira-babel-5361-4x branch March 20, 2025 04:54
shalinilohia50 added a commit to amazon-aurora/babelfish_extensions that referenced this pull request Mar 20, 2025
…ostgresql#3560)

When a new object is created in Babelfish, its owner should be same as its schema owner.

Upgrade approach: Older objects will continue to have the owner (which can be different than the schema owner). There are functions provided to check the objects where there is owner mismatch between object and its schema. User can run the scripts and update the ownership themselves.

Task: BABEL-5361

Signed-off-by: Shalini Lohia [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants