Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with incorrect precision and scale value is computed of constant with value 0 #3561

Open
wants to merge 12 commits into
base: BABEL_5_X_DEV
Choose a base branch
from

Conversation

rohit01010
Copy link
Contributor

Description

Currently when typmod information is computed of a constant using numeric_get_typmod function, it returns precision = 18 and scale = 0 when constant value is 0 irrespective of its scale. Although this should be the case only if constant value is 0 and its scale is also 0. Fixed this logic by adding a check on scale.

Issues Resolved

BABEL-5655

Test Scenarios Covered

  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Rohit Bhagat added 2 commits March 9, 2025 19:01
@coveralls
Copy link
Collaborator

coveralls commented Mar 10, 2025

Pull Request Test Coverage Report for Build 13963102109

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 75.045%

Totals Coverage Status
Change from base Build 13960538732: 0.001%
Covered Lines: 47552
Relevant Lines: 63365

💛 - Coveralls

Rohit Bhagat added 6 commits March 20, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants