Fixed case expression when one of the branch is NUMERIC and other is of EXACT NUMERIC.

[Yvinayak07]

Issues

CASE statement doesn't gives correct typmod when one of the branch is numeric and other is of exact numeric. The precision is being set 5 and scale is set to 4 in babelfish.
So expected result (123.0000) won't fit in Numeric(5,4). So we need to figure out correct precision and scale in this case.

SELECT CASE
WHEN 1 = 0 THEN 0.0001
ELSE 123
END;
Expected Result (TSQL): 123.0000
Actual Result (Babelfish): "Msg 33557097, Level 16, State 1, Line 2
numeric field overflow"
2)

Changes made to fix the issues

In the tsql_select_common_typmod hook, allowed exact numeric types for calculating correct precision and scale.

cherry-pick from #3584

Task: BABEL-5678
Authored-by: yashneet vinayak [email protected]
Signed-off-by: yashneet vinayak [email protected]

Test Scenarios Covered

• **Use case based -**YES

• **Boundary conditions -**YES

• **Arbitrary inputs -**YES

• **Negative test cases -**YES

• Minor version upgrade tests -

• Major version upgrade tests -

• Performance tests -

• Tooling impact -

• **Client tests -**YES

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[coveralls]

Pull Request Test Coverage Report for Build 13988568610

Details

• 28 of 28 (100.0%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 73.923%

---

Totals
Change from base Build 13970684913:	0.01%
Covered Lines:	43591
Relevant Lines:	58968

---

💛 - Coveralls