chore: delete bridge code #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Heimdall Review Status
|
brendan-defi
force-pushed
the
chore/deprecate-bridge
branch
from
ea1f8b2 to
72cb322
Compare
brendan-defi
requested review from
dschlabach,
cpcramer,
abcrane123,
kirkas and
JFrankfurt
wbnns
previously requested changes
Mar 20, 2025
There was a problem hiding this comment.
UI nit, I think we should ensure there is a horizontal line between the disclaimer and Brid.gg:
We also have this same disclaimer at the bottom of the page (which does have a separator); so could just move that one up which already has an H2 that will create the divider
brendan-defi
force-pushed
the
chore/deprecate-bridge
branch
from
6ad1f5b to
668de4b
Compare
cb-heimdall
dismissed
wbnns’s stale review
Approved review 2702085374 from wbnns is now dismissed due to new commit. Re-request for approval.
|
@wbnns good call, updated to replace the info-disclaimer with the H2'ed version |
dschlabach
approved these changes
Mar 20, 2025
wbnns
approved these changes
Mar 20, 2025
|
Review Error for wbnns @ 2025-03-20 17:38:35 UTC |
abcrane123
approved these changes
Mar 20, 2025
wbnns
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
build,lint, andtestscriptsNotes to reviewers
How has it been tested?
Have you tested the following pages?