Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OnchainKit Badge and Identity Card links #2024

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

cpcramer
Copy link
Contributor

@cpcramer cpcramer commented Mar 18, 2025

What changed? Why?
All links in the Badge and Identity Card documentation page are broken - this PR fixes them.

Screenshot 2025-03-18 at 11 16 09 AM

Notes to reviewers

How has it been tested?
Tested locally.

Have you tested the following pages?

  • [] base.org
  • [] base.org/ecosystem
  • [] base.org/resources
  • [] base.org/build
  • [] base.org/names
  • [] base.org/name/jesse
  • [] base.org/manage-names

Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 6:20pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 6:20pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 18, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@cb-heimdall
Copy link
Collaborator

Review Error for dgca @ 2025-03-18 18:50:50 UTC
User must have write permissions to review

@cb-heimdall
Copy link
Collaborator

Review Error for dgca @ 2025-03-18 19:08:29 UTC
User must have write permissions to review

@cpcramer cpcramer merged commit 39030ef into master Mar 19, 2025
9 checks passed
@cpcramer cpcramer deleted the paul/fix-avatar-and-id-card-links branch March 19, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants