Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch webhook tunnel to cloudflare #20

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Switch webhook tunnel to cloudflare #20

wants to merge 4 commits into from

Conversation

keithmacaulay
Copy link
Contributor

  • Update to use cloudflare tunnel in place of localtunnel for webhook routing
  • Docs also updated to reflect this change

rweinberger
rweinberger requested changes Dec 3, 2024
View reviewed changes
Copy link

@rweinberger rweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments! thank you so much for doing this!!

examples/chem-sync-local-flask/README.md
the webhook URL in Benchling should be:

```
https://hot-ideas-doubt.loca.lt/1/webhooks
https://hot-ideas-doubt.trycloudflare.com/1/webhooks
```

![image info](./docs/update-webhook-url.gif)
Copy link

@rweinberger rweinberger Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, this is a nit but I wonder if we should update the gif on this page as well (in the current gif, the page is the old non-global apps page and the URL is a localtunnel one). I made some new gifs for the workshop branch, you can download and reuse
https://github.com/benchling/app-examples-python/blob/benchtalk-workshop/examples/chem-sync-local-flask/docs/update-webhook-url.gif

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, although the workshop gif also uses the localtunnel url?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rweinberger rweinberger rweinberger requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithmacaulay @rweinberger