-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add documentation about syncing container images and air gap support #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
README.md
Outdated
@@ -43,6 +46,28 @@ $ charts-syncer sync --from-date 2020-05-15 | |||
|
|||
> Date should be in format YYYY-MM-DD | |||
|
|||
## Advanced Usage | |||
|
|||
#### Sync charts and container images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be ###
right?
docs/airgap.md
Outdated
kind: HELM | ||
url: https://charts.trials.tac.bitnami.com/demo | ||
target: | ||
intermediateBundlesPath: /path/to/local/output-dir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use a real, usable, path (e.g. .
, /tmp
, or ./bundles
if we are pre-creating the output folder in the tool)
docs/airgap.md
Outdated
|
||
```yaml | ||
source: | ||
intermediateBundlesPath: /path/to/local/input-dir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! See my comments inline
docs/airgap.md
Outdated
In some situations you may want to sync two Helm chart repositories without direct connectivity between them. | ||
charts-syncer support this scenario via intermediate chart bundles. | ||
|
||
An intermediate chart bundle is just a tarball containing the original chart code plus the container images needed to deploy the chart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add an additional paragraph here, something like.
This intermediate Chart Bundle enables a two-step process where its content will be used to relocate the container images and the rewritten Helm Chart without contacting the source Container images registry or Helm repository. Making the relocation process suitable for disconnected, air-gap target environments
docs/airgap.md
Outdated
|
||
## Step 1: Save chart bundles | ||
|
||
In this first step charts-syncer needs access to the source charts repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source charts repository.
and container images registry
docs/airgap.md
Outdated
url: https://charts.trials.tac.bitnami.com/demo | ||
target: | ||
intermediateBundlesPath: /path/to/local/output-dir | ||
charts: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd not add the filter to the example, I'd just put the minimum required otherwise it can look that this is required when it's not
- wordpress | ||
``` | ||
|
||
Execute charts-syncer as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/as follows/as usual i.e/
The reason for this change is that it does not imply that's the only way to run it but that you can use any of the supported CLI options
docs/airgap.md
Outdated
|
||
Move all the chart bundles from the machine with access to the source repo to the machine with access to the target repo. | ||
|
||
You can do it however you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove this sentence, it sounds too informal.
docs/airgap.md
Outdated
|
||
## Step 3: Load chart bundles | ||
|
||
In this first step charts-syncer needs access to the target charts repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/first/second/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and I'd explain what this step will do.
docs/airgap.md
Outdated
charts-syncer sync --config ./config-load-bundles.yaml | ||
``` | ||
|
||
Once charts-syncer finished preparing the bundles you will see them in the directory set in the `intermediateBundlesPath` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that this is copy pasta
88b02e0
to
066d1f6
Compare
066d1f6
to
ce5603a
Compare
Just some basic documentation about the two recent features added to charts-syncer:
Closes #116