Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation about syncing container images and air gap support #121

Merged
merged 3 commits into from
Dec 20, 2021

Conversation

tompizmor
Copy link
Member

Just some basic documentation about the two recent features added to charts-syncer:

Closes #116

@tompizmor tompizmor added the documentation Improvements or additions to documentation label Dec 16, 2021
Copy link
Contributor

@jotadrilo jotadrilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

README.md Outdated
@@ -43,6 +46,28 @@ $ charts-syncer sync --from-date 2020-05-15

> Date should be in format YYYY-MM-DD

## Advanced Usage

#### Sync charts and container images
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be ### right?

docs/airgap.md Outdated
kind: HELM
url: https://charts.trials.tac.bitnami.com/demo
target:
intermediateBundlesPath: /path/to/local/output-dir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use a real, usable, path (e.g. ., /tmp, or ./bundles if we are pre-creating the output folder in the tool)

docs/airgap.md Outdated

```yaml
source:
intermediateBundlesPath: /path/to/local/input-dir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See my comments inline

docs/airgap.md Outdated
In some situations you may want to sync two Helm chart repositories without direct connectivity between them.
charts-syncer support this scenario via intermediate chart bundles.

An intermediate chart bundle is just a tarball containing the original chart code plus the container images needed to deploy the chart.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add an additional paragraph here, something like.

This intermediate Chart Bundle enables a two-step process where its content will be used to relocate the container images and the rewritten Helm Chart without contacting the source Container images registry or Helm repository. Making the relocation process suitable for disconnected, air-gap target environments

docs/airgap.md Outdated

## Step 1: Save chart bundles

In this first step charts-syncer needs access to the source charts repository.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source charts repository.
and container images registry

docs/airgap.md Outdated
url: https://charts.trials.tac.bitnami.com/demo
target:
intermediateBundlesPath: /path/to/local/output-dir
charts:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd not add the filter to the example, I'd just put the minimum required otherwise it can look that this is required when it's not

- wordpress
```

Execute charts-syncer as follows:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/as follows/as usual i.e/

The reason for this change is that it does not imply that's the only way to run it but that you can use any of the supported CLI options

docs/airgap.md Outdated

Move all the chart bundles from the machine with access to the source repo to the machine with access to the target repo.

You can do it however you want.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this sentence, it sounds too informal.

docs/airgap.md Outdated

## Step 3: Load chart bundles

In this first step charts-syncer needs access to the target charts repository.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/first/second/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I'd explain what this step will do.

docs/airgap.md Outdated
charts-syncer sync --config ./config-load-bundles.yaml
```

Once charts-syncer finished preparing the bundles you will see them in the directory set in the `intermediateBundlesPath`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that this is copy pasta

@tompizmor tompizmor force-pushed the airgap-documentation branch from 88b02e0 to 066d1f6 Compare December 17, 2021 11:22
@migmartri migmartri self-assigned this Dec 20, 2021
@migmartri migmartri force-pushed the airgap-documentation branch from 066d1f6 to ce5603a Compare December 20, 2021 14:29
@migmartri migmartri merged commit e9e8313 into master Dec 20, 2021
@migmartri migmartri deleted the airgap-documentation branch December 20, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document relocate container images feature
3 participants