Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-6431] Reformat the charm.py #22

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charmcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ parts:
source: .
override-build: |
# Ship the charm contents
# curl -sSL https://code.launchpad.net/~pguimaraes/openmessaging-benchmark/+git/openmessaging-benchmark/+artifact/280249/+files/openmessaging-benchmark-0.0.1-ubuntu0-20241119152607-linux-x64.tar.gz | tar -zxvf -
# curl -sSL https://code.launchpad.net/~pguimaraes/openmessaging-benchmark/+git/openmessaging-benchmark/+artifact/308300/+files/openmessaging-benchmark-0.0.1-ubuntu0-20250219140257-linux-x64.tar.gz | tar -zxvf -

# For some reason, getting 23 write error in this curl command.
# moving away to wget
apt update
apt install -y wget
wget https://code.launchpad.net/~pguimaraes/openmessaging-benchmark/+git/openmessaging-benchmark/+artifact/280249/+files/openmessaging-benchmark-0.0.1-ubuntu0-20241119152607-linux-x64.tar.gz
wget https://code.launchpad.net/~pguimaraes/openmessaging-benchmark/+git/openmessaging-benchmark/+artifact/308300/+files/openmessaging-benchmark-0.0.1-ubuntu0-20250219140257-linux-x64.tar.gz
tar -zxvf openmessaging-benchmark-*.tar.gz

mv openmessaging-benchmark-0.0.1-SNAPSHOT/ openmessaging-benchmark/
Expand Down
23 changes: 13 additions & 10 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ convention = "google"

[tool.pyright]
include = ["src"]
extraPaths = ["./lib"]
extraPaths = ["./lib", "src"]
pythonVersion = "3.10"
pythonPlatform = "All"
typeCheckingMode = "basic"
Expand Down
5 changes: 3 additions & 2 deletions src/benchmark/wrapper/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@
import logging
import signal

from core import WorkloadCLIArgsModel
from process import WorkloadToProcessMapping
from prometheus_client import start_http_server

from benchmark.wrapper.core import WorkloadCLIArgsModel
from benchmark.wrapper.process import WorkloadToProcessMapping


class MainWrapper:
"""Main class to manage the benchmark tool."""
Expand Down
5 changes: 3 additions & 2 deletions src/benchmark/wrapper/process.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,15 @@
import time
from abc import ABC, abstractmethod

from core import (
from pydantic import BaseModel

from benchmark.wrapper.core import (
BenchmarkCommand,
BenchmarkMetrics,
ProcessModel,
ProcessStatus,
WorkloadCLIArgsModel,
)
from pydantic import BaseModel

VALID_LOG_LEVELS = ["info", "debug", "warning", "error", "critical"]

Expand Down
Loading
Loading