Add Tink dependency to CashSecuritySdk #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the cleaned up output of cocoapods lib create. Tests have not been successfully run. ref: PRODSQUAD-170
ref: PRODSQUAD-170
Base automatically changed from
chotchkies/PRODSQUAD-170__basic_cocoapods_shell
to
main
September 23, 2022 16:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Tink as a dependency under CashSecuritySdk for later use.
Due to an outstanding issue with Tink not building on Apple silicon it takes the scripts from cash-ios with slight adaptations to hack around the issue. The Readme has been updated to include the additional steps that would be required to integrate the library when building on M1 macs.
There are 2 separate integration methods that need to be accounted for. Only the first has been addressed in this PR.
Development (
:path =>)The Example project integrates CashSecuritySdk as a local dependency which does not copy the Scripts folder into the Pods directory. This requires referencing the scripts via relative paths which is quite fragile. If the structure of the path was changed it will likely stop working.
Standard (
:git =>)This is the normal method of integrating a pod which downloads the required files into
Pods/CashSecuritySdk. In this case the Scripts folder exists in a consistent location. Because the podspec is not a the root of the repository it becomes difficult (perhaps impossible) to reference from a standalone project which is complicating testing out this form of integration.SPM
Until Tink 1.7.0 is released it is not possible to reference it from an SPM package. This prevents
CashSecuritySdkfrom providing aPackage.swiftfile as a separate method of integration.CashAU (ios)
CashAU is using SPM for package management, the code structure remains the same as cash-ios which uses cocoapods and POCs have been done to convert to using pods with minimal code changes but the capacity has not been maintained.