Issue #66: Add search API #129
Conversation
classes/search/cms.php
Outdated
| */ | ||
| public function get_context_url(\core_search\document $doc) { | ||
| $contextmodule = \context::instance_by_id($doc->get('contextid')); | ||
| return new \moodle_url('/mod/cms/view.php', ['id' => $contextmodule->instanceid]); |
There was a problem hiding this comment.
I would suggest to double what the client expects to see as a link to found documents in the search results.
There was a problem hiding this comment.
This is just link and actual result is in doc https://github.com/catalyst/moodle-mod_cms/pull/129/files#diff-965e63736ed197b659eeb7349499abdfc8e2aa372cf1fd0a8ddb6b3467f1bf5aR98
There was a problem hiding this comment.
Yes and what about the link in the search result? It should link to some page, shouldn't it? Please check with the client what they expect, maybe provide some screenshots/video recording for them to understand better.
There was a problem hiding this comment.
I'm asking to the client what they expect.
Meanwhile, I'll leave same here and update other parts of this PR.
TomoTsuyuki
force-pushed
the
issue66-add-searchapi
branch
from
f5c5d5c to
5c4b309
Compare
|
I rebased from the latest code, and also added indexing from default values. |
|
The groupconcat function in Moodle is available from 3.11. |
Implement search area for customfield, which can be set in the "Search setting".